-
Notifications
You must be signed in to change notification settings - Fork 121
chore(deps): bump file-type from 16.5.4 to 21.3.2 in /packages/files #7697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,7 +38,7 @@ | |
| "@open-condo/config": "workspace:^", | ||
| "@open-condo/miniapp-utils": "workspace:^", | ||
| "express": "^4.21.2", | ||
| "file-type": "16.5.4", | ||
| "file-type": "21.3.2", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
This changes the workspace manifest to require Useful? React with 👍 / 👎. |
||
| "formidable": "^3.5.4", | ||
| "jsonwebtoken": "^9.0.0", | ||
| "zod": "^4.0.8" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this package is actually installed at v21,
packages/files/detectMimeType.jsstill doesconst { fromFile } = require('file-type')and then callsfromFile(filepath), but file-type v21 exposesfileTypeFromFileinstead offromFileand documents the package as ESM. In the upload middleware path (packages/files/utils.js), this makes magic-number MIME detection fail for every uploaded file and fall back to the client/formidable MIME value, so spoofed or missing content types are no longer corrected.Useful? React with 👍 / 👎.