Skip to content

feat(address-service): DOMA-13263 pullenti as full functional provider#7761

Open
AleX83Xpert wants to merge 2 commits into
mainfrom
feat/address-service/doma-13263/pullenti-as-provider
Open

feat(address-service): DOMA-13263 pullenti as full functional provider#7761
AleX83Xpert wants to merge 2 commits into
mainfrom
feat/address-service/doma-13263/pullenti-as-provider

Conversation

@AleX83Xpert

@AleX83Xpert AleX83Xpert commented Jun 19, 2026

Copy link
Copy Markdown
Member

Since we have released the heuristics, we can make Pullenti work as a normal provider.

  • saving of addresses, sources, and heuristics
  • suggestions
  • check sources from database (should return the same address as another providers)

Summary by CodeRabbit

  • New Features

    • Address actualization now works for an additional provider, improving coverage when updating addresses.
    • Address search results now include linked source details more consistently.
  • Bug Fixes

    • Address saving now follows the standard flow for all providers, reducing missing or incomplete records.
    • Query enhancement no longer fails when organization lookup data is unavailable.
    • Improved handling when an updated address matches an existing key, with clearer validation and merge behavior.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c2bbaf5f-8a55-410c-a6eb-54e5e222bfad

📥 Commits

Reviewing files that changed from the base of the PR and between ded806e and 6c1165b.

📒 Files selected for processing (7)
  • apps/address-service/domains/address/schema/ActualizeAddressesService.js
  • apps/address-service/domains/common/utils/services/search/plugins/SearchBySource.js
  • apps/address-service/domains/common/utils/services/search/plugins/SearchBySource.spec.js
  • apps/address-service/domains/common/utils/services/search/providers/PullentiSearchProvider.js
  • apps/address-service/domains/common/utils/services/search/searchServiceUtils.js
  • apps/address-service/domains/common/utils/services/search/searchServiceUtils.spec.js
  • apps/address-service/domains/common/utils/services/utils/pullenti/queryBooster.js
✅ Files skipped from review due to trivial changes (1)
  • apps/address-service/domains/common/utils/services/search/providers/PullentiSearchProvider.js
🚧 Files skipped from review as they are similar to previous changes (5)
  • apps/address-service/domains/common/utils/services/search/plugins/SearchBySource.js
  • apps/address-service/domains/common/utils/services/utils/pullenti/queryBooster.js
  • apps/address-service/domains/common/utils/services/search/plugins/SearchBySource.spec.js
  • apps/address-service/domains/common/utils/services/search/searchServiceUtils.spec.js
  • apps/address-service/domains/address/schema/ActualizeAddressesService.js

📝 Walkthrough

Walkthrough

The PR promotes the Pullenti provider from stub/beta to fully operational: it removes provider-specific gating in SearchBySource and searchServiceUtils, implements FIAS-based address actualization in ActualizeAddressesService, hardens the TIN query booster with error handling, and updates tests to cover all providers uniformly.

Changes

Pullenti Provider Promotion

Layer / File(s) Summary
Pullenti provider de-beta and query booster resilience
...search/providers/PullentiSearchProvider.js, ...utils/pullenti/queryBooster.js
Removes the top-of-file Pullenti beta/TODO warning comment, adds inline comments explaining intentionally skipped coordinate heuristics, and wraps DadataSuggestionProvider.getOrganization(tin) in a try/catch that returns the original query on failure.
Remove Pullenti special-casing from search utilities
...search/plugins/SearchBySource.js, ...search/searchServiceUtils.js
SearchBySource.isEnabled now unconditionally returns true. createOrUpdateAddressWithSource removes the Pullenti early-return bypass so all providers go through the standard address upsert pipeline. createReturnObject removes the Pullenti conditional that forced an empty addressSources array.
Full Pullenti actualization in ActualizeAddressesService
...address/schema/ActualizeAddressesService.js
Imports PullentiSearchProvider and replaces the stub Pullenti branch with full FIAS-based actualization: reads house_fias_id, fetches and normalizes via PullentiSearchProvider, derives addressKey and heuristics, skips unchanged keys, merges any existing Address, updates the record, and upserts heuristics while tracking successIds and failures.
Updated search tests
...search/plugins/SearchBySource.spec.js, ...search/searchServiceUtils.spec.js
Adds an "Always enabled" test block asserting SearchBySource.isEnabled returns true for varied inputs. Replaces provider-conditional assertions with a test.each(PROVIDERS) case that verifies address and address-source database interactions for every provider.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 No more "not supported yet," the Pullenti joins the band,
FIAS keys now travel far across the address land.
SearchBySource opens wide — all providers welcome here,
The query booster catches throws without a trace of fear.
From beta days to live production, hopping free at last! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: promoting Pullenti to a fully functional address-service provider.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/address-service/doma-13263/pullenti-as-provider

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AleX83Xpert
AleX83Xpert force-pushed the feat/address-service/doma-13263/pullenti-as-provider branch from 490601d to ab95670 Compare June 19, 2026 12:44
@AleX83Xpert AleX83Xpert added the 🔬 WIP Not intended to be merged right now, it is a work in progress label Jun 19, 2026
@AleX83Xpert
AleX83Xpert force-pushed the feat/address-service/doma-13263/pullenti-as-provider branch from ab95670 to dd8ca13 Compare June 22, 2026 07:10
@AleX83Xpert
AleX83Xpert force-pushed the feat/address-service/doma-13263/pullenti-as-provider branch from dd8ca13 to ded806e Compare June 24, 2026 10:18
…estrictions

* remove Pullenti provider database save restrictions
* enable SearchBySource plugin for all providers
* add error handling in queryBooster
* update tests for always-enabled SearchBySource
* update tests to verify all providers save to database
* chore: add .agents to .gitignore
@AleX83Xpert
AleX83Xpert force-pushed the feat/address-service/doma-13263/pullenti-as-provider branch from ded806e to 6c1165b Compare June 24, 2026 11:36
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔬 WIP Not intended to be merged right now, it is a work in progress

Development

Successfully merging this pull request may close these issues.

2 participants