Skip to content

feat(resident-app): DOMA-13377 support voipIceServers#7781

Merged
YEgorLu merged 2 commits into
mainfrom
feat/resident-app/DOMA-13377/support-voip-ice-servers
Jun 29, 2026
Merged

feat(resident-app): DOMA-13377 support voipIceServers#7781
YEgorLu merged 2 commits into
mainfrom
feat/resident-app/DOMA-13377/support-voip-ice-servers

Conversation

@YEgorLu

@YEgorLu YEgorLu commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated the resident app to the latest bundled version, refreshing the packaged app content.
    • No other user-facing feature changes are indicated in this update.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f0c5f3af-84fa-4e16-a7b5-b4ea80fc5331

📥 Commits

Reviewing files that changed from the base of the PR and between 22f4fb0 and 832cd8f.

📒 Files selected for processing (1)
  • apps/resident-app

📝 Walkthrough

Walkthrough

The apps/resident-app Git submodule pointer is updated from commit b935c5e9d19c5a1b8e95190c17b5c080cabcce04 to 739ff9e3be738df81e07dfc2e794b329e19b070e. No application source files are modified.

Changes

Submodule Pointer Update

Layer / File(s) Summary
resident-app submodule pointer
apps/resident-app
The apps/resident-app subproject commit reference is updated to a new revision.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • SavelevMatthew
  • abshnko

Poem

A tiny pointer hops along,
From one commit to the next,
No source has changed, no diff is long,
Just one submodule text.
🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change by indicating a resident-app update for voipIceServers support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/resident-app/DOMA-13377/support-voip-ice-servers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/resident-app`:
- Line 1: The submodule pointer for apps/resident-app is referencing a
non-existent commit hash (4ad3f6ececb390c90316267ffe4d8919be85e76f) which breaks
the build. Update the gitlink pointer to reference the correct and existing
commit hash that contains the voipIceServers implementation changes from
DOMA-13377. The current valid HEAD appears to be 3f323146—use the exact commit
hash from the resident-app repository that contains the "fix stun to
voipIceServers merge" changes instead of the invalid commit reference.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 621949bb-194f-454f-8613-e8e5bede236d

📥 Commits

Reviewing files that changed from the base of the PR and between c119c77 and 3f32314.

📒 Files selected for processing (1)
  • apps/resident-app

Comment thread apps/resident-app Outdated

@dkoviazin dkoviazin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@SavelevMatthew SavelevMatthew left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but adjust url validation rules please

@abshnko abshnko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@YEgorLu
YEgorLu force-pushed the feat/resident-app/DOMA-13377/support-voip-ice-servers branch from 3f32314 to 0305582 Compare June 26, 2026 12:35

@sitozzz sitozzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@YEgorLu
YEgorLu force-pushed the feat/resident-app/DOMA-13377/support-voip-ice-servers branch from 0305582 to 22f4fb0 Compare June 29, 2026 07:32
@YEgorLu
YEgorLu force-pushed the feat/resident-app/DOMA-13377/support-voip-ice-servers branch from 22f4fb0 to 832cd8f Compare June 29, 2026 07:56
@sonarqubecloud

Copy link
Copy Markdown

@YEgorLu
YEgorLu merged commit 580105b into main Jun 29, 2026
44 checks passed
@YEgorLu
YEgorLu deleted the feat/resident-app/DOMA-13377/support-voip-ice-servers branch June 29, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants