chore(deps): bump mjml from 4.18.0 to 5.0.0#7797
Conversation
dependabot
Bot
added
dependencies
javascript
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a86834820
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "lodash": "^4.17.21", | ||
| "lru-cache": "^7.18.3", | ||
| "mjml": "^4.15.3", | ||
| "mjml": "^5.0.0", |
There was a problem hiding this comment.
With this bump, MJML 5's mjml2html API is async and returns a Promise, but the existing email renderer still does mjml2html(...).html in apps/condo/domains/notification/templates.js:303. For messages rendered only from email.mjml.njk (for example VERIFY_USER_EMAIL and SEND_DAILY_STATISTICS), html becomes undefined, so apps/condo/domains/notification/transports/email.js:51 rejects the send with no text or html argument; please await the conversion (callers already await renderTemplate) or keep a synchronous MJML version.
Useful? React with 👍 / 👎.
8a86834 to
d0deb14
Compare
d0deb14 to
7ae0cef
Compare
7ae0cef to
96309e6
Compare
96309e6 to
dfc25d7
Compare
dfc25d7 to
eb62d8c
Compare
dependabot
Bot
changed the title
eb62d8c to
35df6d2
Compare
35df6d2 to
1be9417
Compare
1be9417 to
f4f5b03
Compare
Bumps [mjml](https://github.com/mjmlio/mjml/tree/HEAD/packages/mjml) from 4.18.0 to 5.0.0. - [Release notes](https://github.com/mjmlio/mjml/releases) - [Commits](https://github.com/mjmlio/mjml/commits/v5.0.0/packages/mjml) --- updated-dependencies: - dependency-name: mjml dependency-version: 5.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
f4f5b03 to
48dbc4c
Compare
|
Bumps mjml from 4.18.0 to 5.0.0.
Release notes
Sourced from mjml's releases.
... (truncated)
Commits
ddb2335v5.0.09aac8c6v5.0.0-beta.21dfbc95v5.0.0-beta.165e81dav5.0.0-alpha.1174f3577Merge pull request #3045 from mjmlio/bugfix/3018-mjml5-ignoreIncludes-allowIn...b8e6a60Merge pull request #3044 from mjmlio/bugfix/attributes-adding-updating-for-co...2eb56d7feature(includes): implemented tighter controls591fd1ebugfix(ignoreIncludes): updated test files6b22a67feature(ignoreIncludes): added option for includePath9b7991fbugfix(border-radius): accept string input