Skip to content

chore(deps): bump mjml from 4.18.0 to 5.0.0 #7797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: main
Choose a base branch
from
+1,189 −5,120
Open

chore(deps): bump mjml from 4.18.0 to 5.0.0 #7797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/condo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
"less-loader": "catalog:",
"lodash": "catalog:",
"lru-cache": "^7.18.3",
"mjml": "^4.15.3",
"mjml": "^5.0.0",

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Await MJML 5 before reading html

With this bump, MJML 5's mjml2html API is async and returns a Promise, but the existing email renderer still does mjml2html(...).html in apps/condo/domains/notification/templates.js:303. For messages rendered only from email.mjml.njk (for example VERIFY_USER_EMAIL and SEND_DAILY_STATISTICS), html becomes undefined, so apps/condo/domains/notification/transports/email.js:51 rejects the send with no text or html argument; please await the conversion (callers already await renderTemplate) or keep a synchronous MJML version.

Useful? React with 👍 / 👎.

"n2words": "1.15.0",
"nanoid": "^3.3.4",
"next": "catalog:",
Expand Down
Loading
Loading