RFC-04: prebuilt-provider collision sweep (script + pinned results)#3
Open
so0k wants to merge 1 commit into
Open
RFC-04: prebuilt-provider collision sweep (script + pinned results)#3so0k wants to merge 1 commit into
so0k wants to merge 1 commit into
Conversation
cdk-terrain PR #296 makes provider-generator abort generation instead of silently overwriting on provider-defined-function method/parameter-name collisions, reserved wrapper-member collisions, and provider-attribute collisions with the generated `functions` getter. Sweep every provider in the cdktn-repository-manager prebuilt catalog (plus the pending grafana/grafana and mongodb/mongodbatlas requests) through the real, compiled sanitizers to confirm none of them trip these hard-fails today: 31/31 clean, 0 collisions, 0 unfetched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the collision sweep requested in the PR #296 review: reproducible evidence that no real provider trips the generator's deliberate collision hard-fails (function method names, reserved wrapper members
constructor/providerLocalName, parameter names, and thefunctions-getter vs provider-attribute collision).What's included
RFCS/04-provider-feature-availability/scripts/collision-sweep.js— imports the exact compiled sanitizers from a cdk-terrain PR-296 build (CDKTN_REPOenv var), no reimplemented name rules; self-tests by injecting synthetic collisions before sweeping the real corpus.data/collision-sweep-manifest.json— pinned provider→version/source manifest: 29 providers from the cdktn-repository-manager catalog + Grafana 4.41.0 and MongoDB Atlas 2.14.0 (pending prebuilt requests New Pre-built Provider Request: MongoDB Atlas cdktn-io/cdktn-repository-manager#27 / #20).data/collision-sweep-results.json— machine-readable per-provider verdicts.Result
31/31 clean — 0 collisions, 0 unfetched; 26 provider-defined functions / 32 parameters exercised (aws 4, google/google-beta 6 each, kubernetes 3, time 3, azurerm 2, grafana 1, local 1). The hard-fails in open-constructs/cdk-terrain#296 are currently unreachable by any provider cdktn prebuilds today or plans to.
Follow-up: open-constructs/cdk-terrain#340 tracks the long-term dedupe strategy and wiring this sweep into the drift check (open-constructs/cdk-terrain#309).