Skip to content
This repository was archived by the owner on Jun 29, 2026. It is now read-only.

fix: panic on missing clusterconnect condition + mark unkown connection as false after controlplane provisioning#62

Merged
jdanieck merged 4 commits into
mainfrom
fix-panic-connectionProbeCondition
Jun 12, 2025
Merged

fix: panic on missing clusterconnect condition + mark unkown connection as false after controlplane provisioning#62
jdanieck merged 4 commits into
mainfrom
fix-panic-connectionProbeCondition

Conversation

@jokuniew

Copy link
Copy Markdown

Description

Please include a summary of the changes and the related issue. List any dependencies that are required for this change.

Fixes:

  • If someone updates infraprovider without ccg update - it'll hit panic: runtime error: invalid memory address or nil pointer dereference due to missing condition in clusterconnect object
  • if someone updates successfully ccg and intelinfraProvider and their cluster already has lost connection - it'll stay in "Unknown" condition status. So I added if controlplane is provisioned - mark clusterConnect's unknown statuses as Error

Any Newly Introduced Dependencies

None.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I agree to use the APACHE-2.0 license for my code changes
  • I have not introduced any 3rd party dependency changes
  • I have performed a self-review of my code

@jokuniew jokuniew self-assigned this Jun 10, 2025
@jokuniew jokuniew marked this pull request as ready for review June 12, 2025 14:34
@jdanieck jdanieck merged commit b6016f8 into main Jun 12, 2025
20 checks passed
@jdanieck jdanieck deleted the fix-panic-connectionProbeCondition branch June 12, 2025 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants