Enhance README for device mounts and validation in DLStreamer skill#789
Open
wdunia wants to merge 6 commits into
Open
Enhance README for device mounts and validation in DLStreamer skill#789wdunia wants to merge 6 commits into
wdunia wants to merge 6 commits into
Conversation
Strengthen container run guidance in the DLStreamer skill README: always mount both /dev/dri and /dev/accel, and ensure generated README docker run examples include both device mounts when a pipeline may use an NPU. Clarifies that a GPU-only fallback should be presented only as a secondary note for systems without NPU.
Add a pre-run verification in Step 7 to check for required host devices. Includes an example `ls /dev/dri/render* /dev/accel/accel*` command and guidance that if `/dev/accel` is missing the host has no NPU — switch to GPU for validation only and do not change the README's `docker run` command.
Refine instructions around mounting /dev/dri and /dev/accel and add guidance for systems missing XPU devices. Adds a README note to remove the corresponding --device and --group-add lines when a device is not present, and changes the host-check step to explicitly list XPU devices and instruct building the docker run command by removing missing device/group-add entries. Emphasizes choosing inference device priority NPU → GPU → CPU and keeping the generated README generic with all devices listed.
wdunia
requested review from
BaoHuiling,
OskarFiedot,
ZiningLi,
dmichalo,
jmotow,
marcin-wadolkowski,
mholowni,
msmiatac,
nszczygl9,
oonyshch,
pbartosik,
qianlongding,
tbujewsk,
tjanczak,
walidbarakat,
yangjianfeng1208 and
yunowo
as code owners
April 17, 2026 15:25
Update SKILL.md to instruct users to verify available XPU devices on the host before running the container (ls /dev/dri/render* /dev/accel/accel*). Advise removing --device and --group-add lines for missing devices when building the docker run command, and recommend selecting inference device priority NPU → GPU → CPU. Preserve README wording (keep all devices listed with a note to remove absent device lines).
tbujewsk
reviewed
May 6, 2026
Update .github/skills/dlstreamer-coding-agent/SKILL.md to change the inference device selection priority from NPU → GPU → CPU to GPU → NPU → CPU. This makes GPUs the preferred device when available; the README wording remains generic and still instructs to remove device/group-add lines for devices not present on the host.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix ambiguous device mounting instructions in DL Streamer Coding Agent SKILL.md that caused the agent to generate incorrect docker run commands — either hard-coding --device /dev/accel on hosts without NPU (causing runtime errors) or omitting it entirely on hosts with NPU (missing hardware acceleration).
Changes (Step 5 — Run, Debug and Validate):
This ensures:
Fixes # (issue)
Any Newly Introduced Dependencies
None.
How Has This Been Tested?
Validated on this branch by running the DLStreamer Coding Agent with the updated SKILL.md
Checklist: