[DO NOT MERGE] RFC Model Contract#1027
Draft
rajeshgangireddy wants to merge 7 commits into
Draft
Conversation
Adds the main spec, companion ModelCard doc, and device management placeholder. Ref: open-edge-platform#1001
mpryahin
reviewed
May 29, 2026
|
|
||
| ### `TorchModel` — torch-aware intermediate | ||
|
|
||
| **Currently:** All torch models inherit `Model(nn.Module)` directly. There's no intermediate class — each model independently implements predict() returning `list[dict[str, torch.Tensor]]`. |
Contributor
There was a problem hiding this comment.
I like how AI is shouting about the Torch problem on every corner 😂
Contributor
|
Thanks @rajeshgangireddy! I like your proposal and I fully aligned on it. |
LenaRudaya
reviewed
Jun 3, 2026
| bboxes: np.ndarray | None = None # (N, 4) xyxy | ||
| points: np.ndarray | None = None # (N, K, 2) | ||
| scores: np.ndarray | None = None # (N,) | ||
| categories: list[str] = field(default_factory=lambda: ["object"]) |
Contributor
There was a problem hiding this comment.
I'm not sure we should keep this default factory, if later in the code we use loops like
for category_id, category in zip(sample.category_ids, sample.categories)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to discuss only, DO NOT MERGE.
Model, Model capabilties and DeviceList