ITEP-70724 - Remove FEATURE_FLAG_ANOMALY_REDUCTION (#616)

Author: jpggvilaca

deploy/charts/geti-components/chart/charts/jobs-execution-namespace/values.yaml

@@ -2,7 +2,6 @@ feature_flags_data:
   FEATURE_FLAG_ALLOW_EXTERNAL_KEY_PROJECT_IMPORT: "true"
   FEATURE_FLAG_AMBIENT_MESH: "false"
   FEATURE_FLAG_ANALYTICS_WORKFLOW_ID: "true"
-  FEATURE_FLAG_ANOMALY_REDUCTION: "true"
   FEATURE_FLAG_CAMERA_VIDEO_UPLOAD: "false"
   FEATURE_FLAG_CREDIT_SYSTEM: "false"
   FEATURE_FLAG_DECORD_VIDEO_DECODER: "false"

deploy/charts/istio/gateway/chart/values.yaml

@@ -208,7 +208,6 @@ _internal_defaults_do_not_set:
       "FEATURE_FLAG_ALLOW_EXTERNAL_KEY_PROJECT_IMPORT": "true"
       "FEATURE_FLAG_AMBIENT_MESH": "false"
       "FEATURE_FLAG_ANALYTICS_WORKFLOW_ID": "true"
-      "FEATURE_FLAG_ANOMALY_REDUCTION": "true"
       "FEATURE_FLAG_CAMERA_VIDEO_UPLOAD": "false"
       "FEATURE_FLAG_CREDIT_SYSTEM": "false"
       "FEATURE_FLAG_DECORD_VIDEO_DECODER": "false"

platform/services/config/chart/values.yaml

@@ -41,7 +41,6 @@ feature_flags_data:
   "FEATURE_FLAG_ALLOW_EXTERNAL_KEY_PROJECT_IMPORT": "true"
   "FEATURE_FLAG_AMBIENT_MESH": "false"
   "FEATURE_FLAG_ANALYTICS_WORKFLOW_ID": "true"
-  "FEATURE_FLAG_ANOMALY_REDUCTION": "true"
   "FEATURE_FLAG_CAMERA_VIDEO_UPLOAD": "false"
   "FEATURE_FLAG_CREDIT_SYSTEM": "false"
   "FEATURE_FLAG_DECORD_VIDEO_DECODER": "false"

web_ui/packages/core/src/feature-flags/services/feature-flag-service.interface.ts

@@ -23,7 +23,6 @@ export const DEV_FEATURE_FLAGS = {
     FEATURE_FLAG_LICENSE_VALIDATION: false,
     FEATURE_FLAG_CREDIT_SYSTEM: true,
     FEATURE_FLAG_ORG_QUOTAS: false,
-    FEATURE_FLAG_ANOMALY_REDUCTION: true,
     FEATURE_FLAG_MAINTENANCE_BANNER: false,
     FEATURE_FLAG_KEYPOINT_DETECTION: false,
     FEATURE_FLAG_KEYPOINT_DETECTION_DATASET_IE: false,

web_ui/src/core/datasets/dataset.interface.ts

@@ -73,7 +73,6 @@ export interface DatasetImportToNewProjectIdentifier {
     workspaceId: string;
     projectData: DatasetImportProjectData;
     setAbortController: (uploadId: string, abortController: AbortController) => void;
-    anomalyRevamp: boolean;
 }
 
 export interface DatasetImportTask {

web_ui/src/core/datasets/hooks/use-dataset-import-queries.test.tsx

@@ -101,7 +101,6 @@ describe('useDatasetImportQueries', () => {
                 workspaceId,
                 projectData: mockProjectData,
                 setAbortController,
-                anomalyRevamp: false,
             });
 
             await waitFor(() => {
@@ -110,7 +109,6 @@ describe('useDatasetImportQueries', () => {
                     workspaceId,
                     projectData: mockProjectData,
                     setAbortController,
-                    anomalyRevamp: false,
                 });
             });
         });
@@ -132,7 +130,6 @@ describe('useDatasetImportQueries', () => {
                 workspaceId,
                 projectData: mockProjectData,
                 setAbortController,
-                anomalyRevamp: false,
             });
 
             await waitFor(() => {

web_ui/src/core/datasets/services/api-dataset-import-service.test.ts

@@ -190,7 +190,6 @@ describe('Api dataset import service', () => {
                     labels: [{ name: 'label name', color: '#fff' }],
                 },
                 setAbortController,
-                anomalyRevamp: false,
             });
 
             expect(response).toEqual({ projectId: '' });
@@ -208,7 +207,6 @@ describe('Api dataset import service', () => {
                     labels: [{ name: 'label name', color: '#fff' }],
                 },
                 setAbortController,
-                anomalyRevamp: false,
             });
 
             expect(response).toEqual({ jobId: '321' });

web_ui/src/core/datasets/services/api-dataset-import-service.ts

@@ -112,15 +112,14 @@ export const createApiDatasetImportService: CreateApiService<DatasetImportServic
     const importDatasetToNewProject = async ({
         projectData,
         setAbortController,
-        anomalyRevamp,
         ...workspaceIdentifier
     }: DatasetImportToNewProjectIdentifier): Promise<DatasetImportToNewProjectResponse> => {
         const { uploadId, projectName, taskType, labels } = projectData;
 
         const projectDataDto: DatasetImportToNewProjectPayloadDTO = {
             file_id: uploadId,
             project_name: projectName,
-            task_type: getTaskTypeDTOFromTaskType(taskType, anomalyRevamp),
+            task_type: getTaskTypeDTOFromTaskType(taskType),
             labels,
         };
 
@@ -139,7 +138,6 @@ export const createApiDatasetImportService: CreateApiService<DatasetImportServic
     const importDatasetToNewProjectJob = async ({
         projectData,
         setAbortController,
-        anomalyRevamp,
         ...workspaceIdentifier
     }: DatasetImportToNewProjectIdentifier): Promise<{ jobId: string }> => {
         const abortController = new AbortController();
@@ -150,7 +148,7 @@ export const createApiDatasetImportService: CreateApiService<DatasetImportServic
             {
                 file_id: projectData.uploadId,
                 project_name: projectData.projectName,
-                task_type: getTaskTypeDTOFromTaskType(projectData.taskType, anomalyRevamp),
+                task_type: getTaskTypeDTOFromTaskType(projectData.taskType),
                 labels: projectData.labels,
             },
             { signal: abortController.signal }

web_ui/src/core/datasets/services/utils.ts

@@ -60,12 +60,8 @@ const TASK_TYPE_DTO_FROM_TASK_TYPE: Record<DATASET_IMPORT_TASK_TYPE, DATASET_IMP
     [DATASET_IMPORT_TASK_TYPE.KEYPOINT_DETECTION]: DATASET_IMPORT_TASK_TYPE_DTO.KEYPOINT_DETECTION,
 };
 
-export const getTaskTypeDTOFromTaskType = (
-    taskType: DATASET_IMPORT_TASK_TYPE,
-    anomalyRevamp: boolean
-): DATASET_IMPORT_TASK_TYPE_DTO => {
+export const getTaskTypeDTOFromTaskType = (taskType: DATASET_IMPORT_TASK_TYPE): DATASET_IMPORT_TASK_TYPE_DTO => {
     if (
-        anomalyRevamp &&
         [
             DATASET_IMPORT_TASK_TYPE.ANOMALY_DETECTION,
             DATASET_IMPORT_TASK_TYPE.ANOMALY_SEGMENTATION,

web_ui/src/core/projects/hooks/use-project-actions.hook.ts

@@ -1,7 +1,6 @@
 // Copyright (C) 2022-2025 Intel Corporation
 // LIMITED EDGE SOFTWARE DISTRIBUTION LICENSE
 
-import { useFeatureFlags } from '@geti/core/src/feature-flags/hooks/use-feature-flags.hook';
 import { useApplicationServices } from '@geti/core/src/services/application-services-provider.component';
 import {
     InfiniteData,
@@ -116,7 +115,6 @@ export const useProjectActions = (): UseProjectActions => {
     const client = useQueryClient();
     const { addNotification } = useNotification();
     const { projectService } = useApplicationServices();
-    const { FEATURE_FLAG_ANOMALY_REDUCTION } = useFeatureFlags();
 
     const onError = (error: AxiosError) => {
         addNotification({ message: getErrorMessage(error), type: NOTIFICATION_TYPE.ERROR });
@@ -161,13 +159,7 @@ export const useProjectActions = (): UseProjectActions => {
 
     const createProjectMutation = useMutation({
         mutationFn: ({ workspaceIdentifier, name, domains, projectTypeMetadata }: UseCreateProjectMutation) =>
-            projectService.createProject(
-                workspaceIdentifier,
-                name,
-                domains,
-                projectTypeMetadata,
-                FEATURE_FLAG_ANOMALY_REDUCTION
-            ),
+            projectService.createProject(workspaceIdentifier, name, domains, projectTypeMetadata),
 
         onError,
         onSettled: (_, __, { workspaceIdentifier }) => {
@@ -182,7 +174,7 @@ export const useProjectActions = (): UseProjectActions => {
         UseEditProjectParamsContext
     >({
         mutationFn: ({ projectIdentifier, project }) => {
-            return projectService.editProject(projectIdentifier, project, FEATURE_FLAG_ANOMALY_REDUCTION);
+            return projectService.editProject(projectIdentifier, project);
         },
         onMutate: ({ projectIdentifier, project }) => {
             const queryKey = QUERY_KEYS.PROJECTS_KEY(projectIdentifier.workspaceId);
@@ -251,11 +243,7 @@ export const useProjectActions = (): UseProjectActions => {
 
             const tasks = getEditTasksEntity(project.tasks, tasksMetadata, shouldRevisit);
 
-            return projectService.editProject(
-                { organizationId, workspaceId, projectId },
-                { ...project, tasks },
-                FEATURE_FLAG_ANOMALY_REDUCTION
-            );
+            return projectService.editProject({ organizationId, workspaceId, projectId }, { ...project, tasks });
         },
 
         onError: (error: AxiosError) => {