fix: Buttons padding#1843
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses inconsistent vertical padding on the shared UI Button wrapper by applying a local CSS module class to the underlying React Spectrum Button, aligning it with the expected spacing (per linked issue #6382).
Changes:
- Added a
.buttonstyle inbutton.module.scssto enforce vertical padding via Spectrum dimension tokens. - Updated
Buttonto always apply the new base class viaUNSAFE_className, while preserving any caller-providedUNSAFE_className.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| web_ui/packages/ui/src/button/button.module.scss | Introduces a base .button class to set vertical padding for buttons. |
| web_ui/packages/ui/src/button/button.component.tsx | Applies the base .button class to SpectrumButton and merges it with any existing UNSAFE_className. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
Yeah, forgot. Updated PR description. |
piotrgrubicki
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
✨ Type of Change
Fix open-edge-platform/training_extensions#6382
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: