Skip to content

fix: Buttons padding#1843

Merged
dwesolow merged 1 commit into
mainfrom
dwesolow/fix-button-padding
May 21, 2026
Merged

fix: Buttons padding#1843
dwesolow merged 1 commit into
mainfrom
dwesolow/fix-button-padding

Conversation

@dwesolow
Copy link
Copy Markdown
Contributor

@dwesolow dwesolow commented May 20, 2026

📝 Description

✨ Type of Change

image

Fix open-edge-platform/training_extensions#6382

Select the type of change your PR introduces:

  • 🐞 Bug fix – Non-breaking change which fixes an issue
  • 🚀 New feature – Non-breaking change which adds functionality
  • 🔨 Refactor – Non-breaking change which refactors the code base
  • 💥 Breaking change – Changes that break existing functionality
  • 📚 Documentation update
  • 🔒 Security update
  • 🧪 Tests

🧪 Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

  • ✅ Tested manually
  • 🤖 Run automated end-to-end tests

✅ Checklist

Before submitting the PR, ensure the following:

  • 🔍 PR title is clear and meaningful
  • ✍️ PR description clearly explains the changes and their reason
  • 📝 I have linked the PR to the corresponding GitHub Issues, if any
  • 💬 I have commented my code, especially in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ✅ I have added tests that prove my fix is effective or my feature works

@dwesolow dwesolow self-assigned this May 20, 2026
Copilot AI review requested due to automatic review settings May 20, 2026 14:42
@github-actions github-actions Bot added the UI label May 20, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses inconsistent vertical padding on the shared UI Button wrapper by applying a local CSS module class to the underlying React Spectrum Button, aligning it with the expected spacing (per linked issue #6382).

Changes:

  • Added a .button style in button.module.scss to enforce vertical padding via Spectrum dimension tokens.
  • Updated Button to always apply the new base class via UNSAFE_className, while preserving any caller-provided UNSAFE_className.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
web_ui/packages/ui/src/button/button.module.scss Introduces a base .button class to set vertical padding for buttons.
web_ui/packages/ui/src/button/button.component.tsx Applies the base .button class to SpectrumButton and merges it with any existing UNSAFE_className.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread web_ui/packages/ui/src/button/button.component.tsx
Copy link
Copy Markdown
Contributor

@jpggvilaca jpggvilaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screenshot? :D

@dwesolow
Copy link
Copy Markdown
Contributor Author

screenshot? :D

Yeah, forgot. Updated PR description.

@dwesolow dwesolow enabled auto-merge May 21, 2026 06:51
@dwesolow dwesolow added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit 79fdecc May 21, 2026
32 checks passed
@dwesolow dwesolow deleted the dwesolow/fix-button-padding branch May 21, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Buttons text is misaligned

4 participants