ITEP-32025 Improve FuxNotification component [PART 1]#673
Merged
romanowska merged 11 commits intoJul 11, 2025
Conversation
…ll button; fix credit button notification to work under new implementation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the FuxNotification component to drive its content and behavior from a shared utility based on FUX_NOTIFICATION_KEYS, updates the styling, and wires up the credit-balance button to use the new implementation without the “Dismiss all” option.
- Introduce
getFuxNotificationDatato centralize header/description/link/flow settings - Update
FuxNotificationto consumesettingsKeyandcustomDocUrland branch UI for simple dialogs - Adjust styles and propagate the new props in
credit-balance-button, and register the new key in user-settings
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| web_ui/src/shared/components/header/credit-balance/fux-notification/utils.ts | Add getFuxNotificationData mapping each FUX_NOTIFICATION_KEYS to dialog content |
| web_ui/src/shared/components/header/credit-balance/fux-notification/fux-notification.module.scss | New styles for .dialogWrapper, .fuxDivider, .dialogDescription, etc. |
| web_ui/src/shared/components/header/credit-balance/fux-notification/fux-notification.component.tsx | Refactor component to use settingsKey/customDocUrl and data util |
| web_ui/src/shared/components/header/credit-balance/credit-balance-button.component.tsx | Pass settingsKey and customDocUrl to FuxNotification |
| web_ui/src/shared/components/header/credit-balance/credits-to-consume.module.scss | Change .threeDotsFlashing to inline-flex |
| web_ui/src/core/user-settings/utils.ts | Register default config for CREDIT_BALANCE_BUTTON |
| web_ui/src/core/user-settings/dtos/user-settings.interface.ts | Add new enum value CREDIT_BALANCE_BUTTON to FUX_NOTIFICATION_KEYS |
Comments suppressed due to low confidence (3)
web_ui/src/shared/components/header/credit-balance/fux-notification/utils.ts:13
- Consider adding unit tests for
getFuxNotificationDatato validate that eachFUX_NOTIFICATION_KEYScase returns the correct configuration.
export const getFuxNotificationData = (fuxNotificationId: string): FuxNotificationData => {
web_ui/src/shared/components/header/credit-balance/credit-balance-button.component.tsx:120
- Missing import for FUX_NOTIFICATION_KEYS in this file. Please add
import { FUX_NOTIFICATION_KEYS } from '../../../../../core/user-settings/dtos/user-settings.interface';at the top.
settingsKey={FUX_NOTIFICATION_KEYS.CREDIT_BALANCE_BUTTON}
web_ui/src/shared/components/header/credit-balance/fux-notification/fux-notification.component.tsx:35
- [nitpick] The destructured
docUrlhere shadows the importeduseDocsUrlhook namespace. Consider renaming todataDocUrlor similar to improve clarity.
const { header, description, nextStepId, previousStepId, showDismissAll, docUrl } =
jpggvilaca
reviewed
Jul 10, 2025
jpggvilaca
reviewed
Jul 10, 2025
jpggvilaca
reviewed
Jul 10, 2025
jpggvilaca
approved these changes
Jul 11, 2025
pplaskie
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Improve FuxNotification component to better resemble the soon-to-be deprecated CoachMark component. On this PR only the case of notification without the Dismiss all option was improved. The existing Credit Button notification was fixed to correctly use the new implementation.
On next PRs:
Fix implementation for more advanced notifications
Use FuxNotification implementation instead of CoachMark
JIRA: ITEP-32025
✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: