Restructure workflows directory#679
Merged
Merged
Conversation
…o albert/reenable-log-loop
AlbertvanHouten
changed the title
AlbertvanHouten
requested review from
a team,
Radwan-Ibrahim,
jcchr,
leoll2,
mpryahin and
piotrgrubicki
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restructures the workflows directory by removing the geti_domain and otx_domain folders and relocating their contents under the new top-level workflows structure. Key updates include:
- Adjusted dependency paths in all
pyproject.tomlfiles to reflect the new directory layout. - Introduced new
Makefileand updatedDockerfilepaths for each workflow module. - Removed legacy
geti_domainMakefiles and updated GitHub component filters and chart templates to point at the new locations.
Reviewed Changes
Copilot reviewed 23 out of 418 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| interactive_ai/workflows/project_ie/pyproject.toml | Updated tool.uv.sources paths for libs and migration |
| interactive_ai/workflows/project_ie/Makefile | Added Makefile with shared-workflows include |
| interactive_ai/workflows/project_ie/Dockerfile | Fixed COPY and WORKDIR paths |
| interactive_ai/workflows/optimize/pyproject.toml | Updated dependency source paths |
| interactive_ai/workflows/optimize/Makefile | Added Makefile with shared-workflows include |
| interactive_ai/workflows/optimize/Dockerfile | Updated COPY and WORKDIR paths |
| interactive_ai/workflows/model_test/pyproject.toml | Adjusted tool.uv.sources for libs |
| interactive_ai/workflows/model_test/Makefile | Added Makefile with shared-workflows include |
| interactive_ai/workflows/model_test/Dockerfile | Fixed COPY and WORKDIR paths |
| interactive_ai/workflows/geti_domain/train/Makefile | Removed legacy Makefile |
| interactive_ai/workflows/geti_domain/project_ie/Makefile | Removed legacy Makefile |
| interactive_ai/workflows/geti_domain/optimize/Makefile | Removed legacy Makefile |
| interactive_ai/workflows/geti_domain/model_test/Makefile | Removed legacy Makefile |
| interactive_ai/workflows/geti_domain/dataset_ie/Makefile | Removed legacy Makefile |
| interactive_ai/workflows/dataset_ie/pyproject.toml | Updated dependency source paths |
| interactive_ai/workflows/dataset_ie/job/utils/exceptions.py | Corrected comment path reference |
| interactive_ai/workflows/dataset_ie/Makefile | Added Makefile with shared-workflows include |
| interactive_ai/workflows/dataset_ie/Dockerfile | Updated COPY and WORKDIR paths |
| interactive_ai/workflows/common/pyproject.toml | Adjusted source paths for common libs |
| interactive_ai/workflows/common/Makefile | Corrected Makefile.shared-workflows include path |
| deploy/charts/flyte-core/chart/templates/jobs/workflow-registration.yaml | Updated workflow registration path |
| .github/components-path-filters.yml | Updated path filters to new workflow directories |
| .github/components-config.yaml | Updated component entries for new workflow locations |
Comments suppressed due to low confidence (1)
interactive_ai/workflows/dataset_ie/job/utils/exceptions.py:99
- [nitpick] Update the referenced path to point to the new common tasks utils location, for example
interactive_ai/workflows/common/jobs_common/tasks/utils/progress.py.
# class name will be desplayed as Code (see src/jobs/common/jobs_common/tasks/utils/progress.py)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
leoll2
reviewed
Jul 14, 2025
Contributor
leoll2
left a comment
leoll2
left a comment
There was a problem hiding this comment.
One comment, LGTM. Please run BDD tests ("all") to make sure that all workfows still work
…o albert/restructure-workflows-directory
…ectory' into albert/restructure-workflows-directory
…o albert/restructure-workflows-directory
…o albert/restructure-workflows-directory
leoll2
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Remove geti_domain and otx domain folders. otx domain trainer is now included in the train workflow folder.
https://jira.devtools.intel.com/browse/ITEP-32047
https://github.com/intel-innersource/applications.ai.geti.geti-release/actions/runs/16266867605/job/45984726711
✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: