Removed validation policy from template#700
Open
magerstam wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the image extension workflow ADR to remove template/schema-level validation policy and instead describe post-composition validation/comparison as explicit CLI behavior, keeping templates focused on composition intent and shifting operational verification to execution workflows.
Changes:
- Removes the previously proposed template-embedded
validationpolicy section from the ADR’s schema recommendation. - Introduces a simplified post-compose comparison interface proposal via
--compare-report <sbom|full>. - Clarifies that automated CVE checks and automated boot testing are out of scope for the composition command.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
|
LGTM. While we are at it can we rename file to adr-image-overlay.md? |
srmungar
reviewed
Jun 30, 2026
| templates focused on image intent and keeps operational checks in execution | ||
| workflows. | ||
|
|
||
| ### 1. Fresh Image Composition |
Contributor
There was a problem hiding this comment.
The following may be considered to simplify template creation overall.
- Image Creation Modes inferred implicitly
Create Mode: No baseline source path specified → Build image from scratch with minimal packages
Overlay Mode: Baseline source path provided → Apply modifications to existing image - Output Format Configuration
Use the existing template's output format field (raw, ISO, VMDK, etc.) to specify the final image format for overlay operations. - ISO Remastering
ISO remastering should be treated as a standalone feature with its own dedicated section, separate from the baseline section of the overlay mode. - Conflict Resolution Policy
Add a dedicated "Conflict Resolution Policy" section to define how conflicts are handled during overlay operations. - Partitioning Scheme Limitations
Current Issue: The template doesn't clearly specify whether repartitioning is supported in overlay mode.
Recommendation: If repartitioning is allowed with overlay images, the ICT should only support:
Extension of existing partitioning schemes, not complete overwriting or creation of entirely new partitioning scheme.This approach maintains compatibility with the base image while allowing controlled modifications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR
Description
This PR updates the ADR for image extension workflows to simplify post-composition validation and better separate composition intent from operational verification behavior. The previous ADR draft introduced several validation-related CLI parameters, which increased complexity and blurred ownership between template-defined configuration and runtime validation execution. This update keeps template/schema responsibilities focused on image composition, while moving comparison behavior into a single, explicit post-composition CLI option.
baseline.source.pathin the template (overlay mode).Any Newly Introduced Dependencies
How Has This Been Tested?