chore(comments): remove comment in annotations import#378
Merged
Conversation
tybulewicz
changed the title
mgumowsk
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Our code includes
from __future__ import annotationsstatements, some of those were marked as to be removed when moved to Python 3.10 - it was believed at that time that such imports will not be needed anymore.annotationsare still needed - as mentined in https://docs.python.org/3/library/__future__.html#id2 inclusion of that behavior was not included in Python 3.10 or 3.11, and finally posponed indefinitely.In effect comments advising removal of imports were removed.
Fixes #363
Before submitting