Skip to content

refactor: model parameters definition#439

Merged
tybulewicz merged 2 commits into
masterfrom
mgumowsk/431-simplify-base-classes
Nov 17, 2025
Merged

refactor: model parameters definition#439
tybulewicz merged 2 commits into
masterfrom
mgumowsk/431-simplify-base-classes

Conversation

@mgumowsk

Copy link
Copy Markdown
Contributor

What does this PR do?

This refactor introduces a refactor model_api codebase by centralizing parameters management.

Benefits of the refactor:

  • Reduced code duplication. Before refactor each model class define its own parameter entries with duplicate entries and descriptions
  • Simplified python module imports in model classes. Import only ParametersRegistry instead of specific parameter types like BooleanValue, ListValaue, etc..
  • Improved maintainability. Parameter definitions are centralized, making updates and bug fixes easier.
  • Cleaner model implementation. No more need to boilerplate parameters in init function.
  • Modular parameter composition

This enables next refactor: common preprocessing and postprocessing pipelines, common parameters handling (for eg. label loading)

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@mgumowsk mgumowsk requested a review from a team as a code owner November 12, 2025 09:51
@github-actions github-actions Bot added tests Related to tests python python related changes labels Nov 12, 2025
@tybulewicz tybulewicz added this pull request to the merge queue Nov 17, 2025
Merged via the queue into master with commit 6c211be Nov 17, 2025
12 checks passed
@tybulewicz tybulewicz deleted the mgumowsk/431-simplify-base-classes branch November 17, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python python related changes tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants