Skip to content

feat: add OVMSAdapter#498

Merged
tybulewicz merged 21 commits into
masterfrom
ttybulew/restore-ovms-adapter
Mar 5, 2026
Merged

feat: add OVMSAdapter#498
tybulewicz merged 21 commits into
masterfrom
ttybulew/restore-ovms-adapter

Conversation

@tybulewicz

@tybulewicz tybulewicz commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR re-introduces a new OVMSAdapter to enable running Model API wrappers against models served by OpenVINO Model Server (OVMS) via the Triton HTTP client, and wires it into model creation, docs, examples, and CI.

Fixes #495

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@github-actions github-actions Bot added tests Related to tests python python related changes docs Related to documentation build Related to build scripts samples labels Mar 2, 2026
@tybulewicz tybulewicz force-pushed the ttybulew/restore-ovms-adapter branch from 1ee6dc0 to 8f972a4 Compare March 2, 2026 11:02
@tybulewicz tybulewicz force-pushed the ttybulew/restore-ovms-adapter branch from a859380 to 9e47fc9 Compare March 2, 2026 13:01
@tybulewicz tybulewicz requested a review from Copilot March 2, 2026 13:42
@tybulewicz tybulewicz marked this pull request as ready for review March 2, 2026 13:42
@tybulewicz tybulewicz requested review from a team as code owners March 2, 2026 13:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new OVMSAdapter to enable running Model API wrappers against models served by OpenVINO Model Server (OVMS) via the Triton HTTP client, and wires it into model creation, docs, examples, and CI.

Changes:

  • Added OVMSAdapter implementation plus unit tests for URL parsing.
  • Updated Model API to auto-detect OVMS model URLs and instantiate OVMSAdapter.
  • Added docs/examples and a new CI job to exercise the serving API flow end-to-end.

Reviewed changes

Copilot reviewed 14 out of 16 changed files in this pull request and generated 20 comments.

Show a summary per file
File Description
src/model_api/adapters/ovms_adapter.py New inference adapter for OVMS using tritonclient.http
tests/unit/adapters/test_ovms_adapter.py Unit tests for OVMSAdapter.parse_model_arg()
src/model_api/models/model.py Auto-detect OVMS URLs in create_model(); minor param access/error message updates
src/model_api/tilers/tiler.py Adjusts rt_info exception handling during tiler config loading
src/model_api/adapters/__init__.py Exports OVMSAdapter from the adapters package
src/model_api/adapters/ovms_adapter.md New adapter documentation (usage, OVMS setup)
docs/source/adapters/ovms_adapter.md Adds Sphinx docs page for the OVMS adapter
docs/source/adapters/index.md Adds OVMS adapter to adapter docs index
examples/serving_api/run.py New runnable serving example using an OVMS URL
examples/serving_api/README.md New instructions for the serving example
pyproject.toml Adds optional dependency extra ovms for tritonclient[http]
src/README.md Updates package README with OVMS adapter info
README.md Updates top-level README to mention serving and OVMS
.github/workflows/pre_commit.yml Adds a new serving_api-tests CI job using OVMS docker image
.gitignore Ignores ovms_models/ generated during serving tests

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/model_api/adapters/ovms_adapter.py Outdated
Comment thread src/model_api/adapters/ovms_adapter.py Outdated
Comment thread src/model_api/adapters/ovms_adapter.md Outdated
Comment thread examples/serving_api/run.py Outdated
Comment thread examples/serving_api/README.md Outdated
Comment thread examples/serving_api/README.md Outdated
Comment thread src/model_api/adapters/ovms_adapter.py
Comment thread src/README.md Outdated
Comment thread README.md Outdated
Comment thread .github/workflows/pre_commit.yml
mgumowsk
mgumowsk previously approved these changes Mar 2, 2026
@tybulewicz tybulewicz enabled auto-merge March 2, 2026 15:55
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@tybulewicz tybulewicz dismissed stale reviews from mgumowsk and AlexanderBarabanov via 6bfd42a March 2, 2026 16:05
tybulewicz and others added 8 commits March 2, 2026 17:06
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 16 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Comment thread tests/unit/adapters/test_ovms_adapter.py
Comment thread src/model_api/adapters/ovms_adapter.py
Comment thread src/model_api/adapters/ovms_adapter.py
Comment thread src/model_api/adapters/ovms_adapter.py
Comment thread src/model_api/tilers/tiler.py
Comment thread src/model_api/adapters/ovms_adapter.md
tybulewicz and others added 2 commits March 3, 2026 10:44
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mgumowsk
mgumowsk previously approved these changes Mar 3, 2026
@tybulewicz tybulewicz requested a review from mgumowsk March 5, 2026 12:31
@tybulewicz tybulewicz added this pull request to the merge queue Mar 5, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 5, 2026
@tybulewicz tybulewicz added this pull request to the merge queue Mar 5, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 5, 2026
@tybulewicz tybulewicz added this pull request to the merge queue Mar 5, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 5, 2026
@tybulewicz tybulewicz added this pull request to the merge queue Mar 5, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 5, 2026
@tybulewicz tybulewicz added this pull request to the merge queue Mar 5, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 5, 2026
@tybulewicz tybulewicz added this pull request to the merge queue Mar 5, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 5, 2026
@tybulewicz tybulewicz added this pull request to the merge queue Mar 5, 2026
Merged via the queue into master with commit a7d3f94 Mar 5, 2026
90 of 99 checks passed
@tybulewicz tybulewicz deleted the ttybulew/restore-ovms-adapter branch March 5, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Related to build scripts docs Related to documentation python python related changes samples tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restore OVMSAdapter

5 participants