Skip to content

chore: Standardize Method Naming in Mapping Service#1407

Merged
ltalarcz merged 8 commits into
mainfrom
mapping-snake-case-refactoring
May 25, 2026
Merged

chore: Standardize Method Naming in Mapping Service#1407
ltalarcz merged 8 commits into
mainfrom
mapping-snake-case-refactoring

Conversation

@ltalarcz
Copy link
Copy Markdown
Contributor

@ltalarcz ltalarcz commented May 7, 2026

📝 Description

This pull request standardizes function and method naming across the codebase by converting all function names from camelCase to snake_case. This improves code readability and aligns with Python's PEP 8 style guidelines. The changes affect the main API service, model interface, model implementation, mesh utilities, and service entry points.

API Service and Entry Point Standardization:

  • All Flask route handlers, error handlers, and core API service functions in api_service_base.py have been renamed to use snake_case (e.g., healthCheckhealth_check, runModelInferencerun_model_inference, startAppstart_app). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]
  • The service initialization override in mapanything_service.py is updated to use the new initialize_model name. [1] [2]

Model Interface and Implementation:

  • All abstract methods in model_interface.py are renamed to snake_case (e.g., loadModelload_model, runInferencerun_inference). [1] [2] [3] [4] [5] [6]
  • Corresponding method implementations in mapanything_model.py are also renamed, including internal helpers and calls to these methods. [1] [2] [3] [4] [5] [6] [7]

Mesh Utility Functions:

  • Utility functions in mesh_utils.py are renamed to snake_case (e.g., createPointcloudFromMeshcreate_pointcloud_from_mesh, getMeshInfoget_mesh_info). [1] [2]

These changes ensure consistency throughout the codebase and make the code easier to maintain and understand for all contributors.

✨ Type of Change

Select the type of change your PR introduces:

  • 🐞 Bug fix – Non-breaking change which fixes an issue
  • 🚀 New feature – Non-breaking change which adds functionality
  • 🔨 Refactor – Non-breaking change which refactors the code base
  • 💥 Breaking change – Changes that break existing functionality
  • 📚 Documentation update
  • 🔒 Security update
  • 🧪 Tests
  • 🚂 CI

🧪 Testing Scenarios

Describe how the changes were tested and how reviewers can test them too:

  • ✅ Tested manually
  • 🤖 Ran automated end-to-end tests

✅ Checklist

Before submitting the PR, ensure the following:

  • 🔍 PR title is clear and descriptive
  • 📝 For internal contributors: If applicable, include the JIRA ticket number (e.g., ITEP-123456) in the PR title. Do not include full URLs
  • 💬 I have commented my code, especially in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ✅ I have added tests that prove my fix is effective or my feature works

@ltalarcz ltalarcz enabled auto-merge (squash) May 20, 2026 08:40
@ltalarcz ltalarcz disabled auto-merge May 22, 2026 06:21
@ltalarcz ltalarcz changed the title chore: Standardize Method Naming in Mapping Service [DO NOT MERGE] chore: Standardize Method Naming in Mapping Service May 22, 2026
@ltalarcz ltalarcz changed the title [DO NOT MERGE] chore: Standardize Method Naming in Mapping Service chore: Standardize Method Naming in Mapping Service May 25, 2026
@ltalarcz ltalarcz enabled auto-merge (squash) May 25, 2026 11:10
@ltalarcz ltalarcz merged commit af7f040 into main May 25, 2026
33 checks passed
@ltalarcz ltalarcz deleted the mapping-snake-case-refactoring branch May 25, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants