ITEP-91742: Ensure scene updates always emit DB topic notifications#1420
Conversation
Agent-Logs-Url: https://github.com/open-edge-platform/scenescape/sessions/15ee0210-6a1e-478e-a9e1-c83c3de9f39b Co-authored-by: saratpoluri <1325325+saratpoluri@users.noreply.github.com>
|
@sbelhaik : this test: https://jira.devtools.intel.com/secure/Tests.jspa#/testCase/NEX-T12750 |
fc5ef51 to
28052c3
Compare
There was a problem hiding this comment.
Please fix trailing hitespace linter issue:
Trailing whitespace: /home/runner/work/scenescape/scenescape/controller/tests/test_database_update_triggers_tracker_creation.py
Trailing whitespace: /home/runner/work/scenescape/scenescape/manager/tests/tc_scene_creation_sends_update.py
NEX-T10448: FAIL
Done. |
📝 Description
Scene update notifications on the DB topic were dropped for update paths with no validated field deltas, causing downstream consumers to miss scene refresh events. This change restores a guaranteed post-commit notification path for those cases.
Scene.notifydbupdate()to enqueuesendUpdateCommand(scene_id=self.pk)on transaction commit.SceneSerializer.create_update, whenis_updateandvalidated_datais effectively empty, callinstance.notifydbupdate()instead of silently returning.JIRA: ITEP-91742
✨ Type of Change
Select the type of change your PR introduces:
🧪 Testing Scenarios
Describe how the changes were tested and how reviewers can test them too:
✅ Checklist
Before submitting the PR, ensure the following: