fix(tools): accept patch-release tag provenance in publish-existing - #531
Merged
Conversation
A local patch-release tags and pushes; the CI publish-existing run then refused that correct immutable tag because the tag's evidence id belongs to the patch-release run, not the publish-existing run (the 0.41.2 publish failure). decideTagAction now also keeps a conflicting tag when the tag commit's evidence record has kind 'patch-release' — publish passed and ancestor checks still apply. npm publish itself skips already-published versions, so the resumed run only fills the remaining gap (GitHub release + evidence finalize).
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
|
APIError: Insufficient Balance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the 0.41.2 publish: the local patch-release tagged and pushed v0.41.2; the CI publish-existing run refused that correct immutable tag (evidence-id mismatch between the two phases). decideTagAction now keeps a conflicting ancestor tag when the tag commit's evidence record has kind 'patch-release'. Tests cover the two-phase case plus refusal without publish proof. Required on main before re-dispatching the 0.41.2 publish (the workflow runs from main; npm publish skips already-published versions, so the re-run only closes the GitHub-release + evidence gap).