fix(0.42): alpha.7 light-fullstack floor (TP-5.7) - #617
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Deploying openelement with
|
| Latest commit: |
8a1c970
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://04097fc7.lessjs.pages.dev |
| Branch Preview URL: | https://feature-0-42-0-alpha-7-light.lessjs.pages.dev |
Contributor
|
APIError: Insufficient Balance |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| for (const filePath of candidates) { | ||
| if (!filePath.startsWith(distDir)) continue; | ||
| if (!existsSync(filePath) || !statSync(filePath).isFile()) continue; | ||
| const body = readFileSync(filePath); |
Contributor
|
APIError: Insufficient Balance |
Contributor
|
APIError: Insufficient Balance |
…on redirect -> throw
Contributor
|
APIError: Insufficient Balance |
Contributor
|
APIError: Insufficient Balance |
Contributor
|
APIError: Insufficient Balance |
Playwright with javaScriptEnabled:false sends Origin:null on form submissions, which ADR-0121's CSRF check tries to parse as URL and rejects with 403. Pass env via the nitro event and set OPEN_ELEMENT_DISABLE_CSRF=1 in the webServer command.
Contributor
|
APIError: Insufficient Balance |
Starter template added @openelement/adapter-vite/nitro-mount (#601) but consumer-local.ts import surface check wasn't updated.
Contributor
|
APIError: Insufficient Balance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TP-5.7 ship gate for
0.42.0-alpha.7WC light fullstack floor.Closes #597 #598 #599 #600 #601 #602 #607 #608 #611 #616
Must-close
__scanSubmitRootsgated ([0.42-r3 H1] islands without enhancedForms call undefined __scanSubmitRoots after hydrate #597),getAttribute(action)([0.42-r3 H2] enhanced submit uses form.action IDL — name="action" fields break fetch URL #598), per-form seq ([0.42-r3 H3] multi-form enhance: global last-wins sequence drops successful cross-form responses #599)cli/start+cli/previewfail-loud; create starter import map ([0.42-r3 H5] request-time first mile: start/serve path, import map completeness, preview fail-loud on dynamic #601)serializeAttrsattr-name allowlist ([0.42-r3 M1] serializeAttrs must reject unsafe attribute names (SSR XSS primitive) #602)latest([0.42-r3 M6] npm dist-tag discipline: latest must track last stable, not alpha #607)Plan
VERSION_PLAN TP-5.7 / light fullstack promise.
Test plan
deno testentry-generators, entry-renderer, ssg-render, render-ir, create cli, publish-npm, npm-release-verifierdeno task package-surface:check0.42.0-alpha.7(version bump separate or follow-up)npm dist-tag add @openelement/*@0.41.2 latestif still on alpha