Skip to content

Prototest DEA#57

Merged
finozzifa merged 68 commits into
prototype-2from
issue_46_prototest_dea
Nov 19, 2025
Merged

Prototest DEA#57
finozzifa merged 68 commits into
prototype-2from
issue_46_prototest_dea

Conversation

@finozzifa
Copy link
Copy Markdown
Member

@finozzifa finozzifa commented Sep 30, 2025

Closes # (if applicable).
Issue #46

Changes proposed in this Pull Request

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Data source for new technologies is clearly stated.
  • Newly introduced dependencies are added to environment.yaml (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the GPLv3 license.

@euronion euronion changed the base branch from master to prototype-2 September 30, 2025 09:02
@finozzifa
Copy link
Copy Markdown
Member Author

column est goes into Technology.case

@euronion
Copy link
Copy Markdown
Member

Use calamine for reading Excel files please :) PyPSA#190

@euronion
Copy link
Copy Markdown
Member

euronion commented Oct 3, 2025

Also add the source as a Source object and use the webarchive for storing and retrieving the excel file.

Copy link
Copy Markdown
Member

@euronion euronion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, then it is RTM. Nice!

Comment thread REUSE.toml
Comment thread src/technologydata/package_data/dea_energy_storage/sources.json Outdated
Comment thread src/technologydata/package_data/dea_energy_storage/sources.json Outdated
Comment thread src/technologydata/package_data/dea_energy_storage/sources.json Outdated
Comment thread src/technologydata/package_data/schemas/sources.schema.json Outdated
Comment thread src/technologydata/package_data/dea_energy_storage/dea_energy_storage.py Outdated
Comment thread src/technologydata/package_data/dea_energy_storage/dea_energy_storage.py Outdated
Comment thread src/technologydata/package_data/dea_energy_storage/dea_energy_storage.py Outdated
@finozzifa finozzifa mentioned this pull request Nov 7, 2025
5 tasks
Copy link
Copy Markdown
Member

@euronion euronion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the capacities and then this is RTM :)

@finozzifa finozzifa merged commit 471b617 into prototype-2 Nov 19, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants