Skip to content

perf(rust): eliminate context cloning and merge duplicated evaluation paths #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aepfli merged 2 commits into from
Feb 22, 2026
Merged

perf(rust): eliminate context cloning and merge duplicated evaluation paths #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3348211
perf(rust): eliminate context cloning and merge duplicated evaluation…
aepfli Feb 22, 2026
13807e5
fix(python): pass owned Value to evaluator API
aepfli Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions benches/comparison.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ fn comparison_simple_flag_evaluator(c: &mut Criterion) {
let context = json!({});

c.bench_function("comparison_simple_flag_evaluator", |b| {
b.iter(|| evaluator.evaluate_flag(black_box("simpleFlag"), black_box(&context)))
b.iter(|| evaluator.evaluate_flag(black_box("simpleFlag"), black_box(context.clone())))
});
}

Expand Down Expand Up @@ -116,7 +116,7 @@ fn comparison_complex_flag_evaluator(c: &mut Criterion) {
let context = json!({"tier": "standard", "score": 75});

c.bench_function("comparison_complex_flag_evaluator", |b| {
b.iter(|| evaluator.evaluate_flag(black_box("complexFlag"), black_box(&context)))
b.iter(|| evaluator.evaluate_flag(black_box("complexFlag"), black_box(context.clone())))
});
}

Expand Down
20 changes: 10 additions & 10 deletions benches/concurrency.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ fn concurrent_simple_1t(c: &mut Criterion) {
let context = json!({});

c.bench_function("concurrent_simple_1t", |b| {
b.iter(|| evaluator.evaluate_flag(black_box("boolFlag"), black_box(&context)))
b.iter(|| evaluator.evaluate_flag(black_box("boolFlag"), black_box(context.clone())))
});
}

Expand All @@ -122,7 +122,7 @@ fn concurrent_simple_4t(c: &mut Criterion) {
thread::spawn(move || {
let ctx = json!({});
let guard = eval.lock().unwrap();
guard.evaluate_flag(black_box("boolFlag"), black_box(&ctx))
guard.evaluate_flag(black_box("boolFlag"), black_box(ctx))
})
})
.collect();
Expand All @@ -149,7 +149,7 @@ fn concurrent_simple_8t(c: &mut Criterion) {
thread::spawn(move || {
let ctx = json!({});
let guard = eval.lock().unwrap();
guard.evaluate_flag(black_box("boolFlag"), black_box(&ctx))
guard.evaluate_flag(black_box("boolFlag"), black_box(ctx))
})
})
.collect();
Expand Down Expand Up @@ -177,7 +177,7 @@ fn concurrent_targeting_4t(c: &mut Criterion) {
let role = if i % 2 == 0 { "admin" } else { "viewer" };
let ctx = json!({"role": role});
let guard = eval.lock().unwrap();
guard.evaluate_flag(black_box("targetedFlag"), black_box(&ctx))
guard.evaluate_flag(black_box("targetedFlag"), black_box(ctx))
})
})
.collect();
Expand Down Expand Up @@ -215,7 +215,7 @@ fn concurrent_mixed_4t(c: &mut Criterion) {
let context = ctx.clone();
thread::spawn(move || {
let guard = eval.lock().unwrap();
guard.evaluate_flag(black_box(key), black_box(&context))
guard.evaluate_flag(black_box(key), black_box(context))
})
})
.collect();
Expand Down Expand Up @@ -251,7 +251,7 @@ fn concurrent_read_write_4t(c: &mut Criterion) {
thread::spawn(move || {
let ctx = json!({});
let guard = eval.lock().unwrap();
guard.evaluate_flag(black_box("boolFlag"), black_box(&ctx))
guard.evaluate_flag(black_box("boolFlag"), black_box(ctx))
})
})
.collect();
Expand Down Expand Up @@ -283,7 +283,7 @@ fn concurrent_simple_16t(c: &mut Criterion) {
thread::spawn(move || {
let ctx = json!({});
let guard = eval.lock().unwrap();
guard.evaluate_flag(black_box("boolFlag"), black_box(&ctx))
guard.evaluate_flag(black_box("boolFlag"), black_box(ctx))
})
})
.collect();
Expand Down Expand Up @@ -314,7 +314,7 @@ fn concurrent_targeting_16t(c: &mut Criterion) {
let role = if i % 2 == 0 { "admin" } else { "viewer" };
let ctx = json!({"role": role});
let guard = eval.lock().unwrap();
guard.evaluate_flag(black_box("targetedFlag"), black_box(&ctx))
guard.evaluate_flag(black_box("targetedFlag"), black_box(ctx))
})
})
.collect();
Expand Down Expand Up @@ -354,7 +354,7 @@ fn concurrent_mixed_16t(c: &mut Criterion) {
let (key, ctx) = workload_defs[i % workload_defs.len()].clone();
thread::spawn(move || {
let guard = eval.lock().unwrap();
guard.evaluate_flag(black_box(key), black_box(&ctx))
guard.evaluate_flag(black_box(key), black_box(ctx))
})
})
.collect();
Expand Down Expand Up @@ -391,7 +391,7 @@ fn concurrent_read_write_16t(c: &mut Criterion) {
thread::spawn(move || {
let ctx = json!({});
let guard = eval.lock().unwrap();
guard.evaluate_flag(black_box("boolFlag"), black_box(&ctx))
guard.evaluate_flag(black_box("boolFlag"), black_box(ctx))
})
})
.collect();
Expand Down
24 changes: 12 additions & 12 deletions benches/evaluation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ fn evaluate_flag_simple(c: &mut Criterion) {
let context = json!({});

c.bench_function("evaluate_flag_simple", |b| {
b.iter(|| evaluator.evaluate_flag(black_box("boolFlag"), black_box(&context)))
b.iter(|| evaluator.evaluate_flag(black_box("boolFlag"), black_box(context.clone())))
});
}

Expand All @@ -87,7 +87,7 @@ fn evaluate_flag_targeting_match(c: &mut Criterion) {
let context = json!({"role": "admin"});

c.bench_function("evaluate_flag_targeting_match", |b| {
b.iter(|| evaluator.evaluate_flag(black_box("targetedFlag"), black_box(&context)))
b.iter(|| evaluator.evaluate_flag(black_box("targetedFlag"), black_box(context.clone())))
});
}

Expand All @@ -97,7 +97,7 @@ fn evaluate_flag_targeting_no_match(c: &mut Criterion) {
let context = json!({"role": "viewer"});

c.bench_function("evaluate_flag_targeting_no_match", |b| {
b.iter(|| evaluator.evaluate_flag(black_box("targetedFlag"), black_box(&context)))
b.iter(|| evaluator.evaluate_flag(black_box("targetedFlag"), black_box(context.clone())))
});
}

Expand All @@ -107,7 +107,7 @@ fn evaluate_flag_complex_targeting(c: &mut Criterion) {
let context = json!({"tier": "standard", "score": 75});

c.bench_function("evaluate_flag_complex_targeting", |b| {
b.iter(|| evaluator.evaluate_flag(black_box("complexFlag"), black_box(&context)))
b.iter(|| evaluator.evaluate_flag(black_box("complexFlag"), black_box(context.clone())))
});
}

Expand All @@ -117,7 +117,7 @@ fn evaluate_flag_disabled(c: &mut Criterion) {
let context = json!({});

c.bench_function("evaluate_flag_disabled", |b| {
b.iter(|| evaluator.evaluate_flag(black_box("disabledFlag"), black_box(&context)))
b.iter(|| evaluator.evaluate_flag(black_box("disabledFlag"), black_box(context.clone())))
});
}

Expand All @@ -127,7 +127,7 @@ fn evaluate_flag_not_found(c: &mut Criterion) {
let context = json!({});

c.bench_function("evaluate_flag_not_found", |b| {
b.iter(|| evaluator.evaluate_flag(black_box("nonexistent"), black_box(&context)))
b.iter(|| evaluator.evaluate_flag(black_box("nonexistent"), black_box(context.clone())))
});
}

Expand Down Expand Up @@ -205,7 +205,7 @@ fn evaluate_flag_simple_small_ctx(c: &mut Criterion) {
let context = small_context();

c.bench_function("evaluate_flag_simple_small_ctx", |b| {
b.iter(|| evaluator.evaluate_flag(black_box("boolFlag"), black_box(&context)))
b.iter(|| evaluator.evaluate_flag(black_box("boolFlag"), black_box(context.clone())))
});
}

Expand All @@ -216,7 +216,7 @@ fn evaluate_flag_simple_large_ctx(c: &mut Criterion) {
let context = large_context();

c.bench_function("evaluate_flag_simple_large_ctx", |b| {
b.iter(|| evaluator.evaluate_flag(black_box("boolFlag"), black_box(&context)))
b.iter(|| evaluator.evaluate_flag(black_box("boolFlag"), black_box(context.clone())))
});
}

Expand All @@ -227,7 +227,7 @@ fn evaluate_flag_targeting_small_ctx(c: &mut Criterion) {
let context = small_context(); // contains "role": "admin" which triggers the match

c.bench_function("evaluate_flag_targeting_small_ctx", |b| {
b.iter(|| evaluator.evaluate_flag(black_box("targetedFlag"), black_box(&context)))
b.iter(|| evaluator.evaluate_flag(black_box("targetedFlag"), black_box(context.clone())))
});
}

Expand All @@ -238,7 +238,7 @@ fn evaluate_flag_targeting_large_ctx(c: &mut Criterion) {
let context = large_context(); // contains "role": "admin" which triggers the match

c.bench_function("evaluate_flag_targeting_large_ctx", |b| {
b.iter(|| evaluator.evaluate_flag(black_box("targetedFlag"), black_box(&context)))
b.iter(|| evaluator.evaluate_flag(black_box("targetedFlag"), black_box(context.clone())))
});
}

Expand All @@ -249,7 +249,7 @@ fn evaluate_flag_complex_targeting_small_ctx(c: &mut Criterion) {
let context = small_context(); // contains "tier": "premium" and "score": 85

c.bench_function("evaluate_flag_complex_targeting_small_ctx", |b| {
b.iter(|| evaluator.evaluate_flag(black_box("complexFlag"), black_box(&context)))
b.iter(|| evaluator.evaluate_flag(black_box("complexFlag"), black_box(context.clone())))
});
}

Expand All @@ -260,7 +260,7 @@ fn evaluate_flag_complex_targeting_large_ctx(c: &mut Criterion) {
let context = large_context(); // contains "tier": "premium" and "score": 85

c.bench_function("evaluate_flag_complex_targeting_large_ctx", |b| {
b.iter(|| evaluator.evaluate_flag(black_box("complexFlag"), black_box(&context)))
b.iter(|| evaluator.evaluate_flag(black_box("complexFlag"), black_box(context.clone())))
});
}

Expand Down
4 changes: 2 additions & 2 deletions benches/scale.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ fn bench_evaluate_static_from_10k(c: &mut Criterion) {
let context = json!({});

c.bench_function("S10_evaluate_static_from_10K_store", |b| {
b.iter(|| evaluator.evaluate_flag(black_box("flag_0000"), black_box(&context)))
b.iter(|| evaluator.evaluate_flag(black_box("flag_0000"), black_box(context.clone())))
});
}

Expand All @@ -117,7 +117,7 @@ fn bench_evaluate_targeting_from_10k(c: &mut Criterion) {
let context = json!({"color": "blue", "targetingKey": "user-123"});

c.bench_function("S11_evaluate_targeting_from_10K_store", |b| {
b.iter(|| evaluator.evaluate_flag(black_box("flag_0014"), black_box(&context)))
b.iter(|| evaluator.evaluate_flag(black_box("flag_0014"), black_box(context.clone())))
});
}

Expand Down
6 changes: 3 additions & 3 deletions examples/evaluators_demo.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ fn main() {

// Test 1: Admin user
let context = json!({"email": "admin@company.com", "tier": "basic"});
let result = evaluator.evaluate_flag("vipFeatures", &context);
let result = evaluator.evaluate_flag("vipFeatures", context);
println!("1️⃣ Admin user (admin@company.com, tier=basic):");
println!(
" → Result: {}, Variant: {}",
Expand All @@ -77,7 +77,7 @@ fn main() {

// Test 2: Premium user
let context = json!({"email": "user@company.com", "tier": "premium"});
let result = evaluator.evaluate_flag("vipFeatures", &context);
let result = evaluator.evaluate_flag("vipFeatures", context);
println!("\n2️⃣ Premium user (user@company.com, tier=premium):");
println!(
" → Result: {}, Variant: {}",
Expand All @@ -87,7 +87,7 @@ fn main() {

// Test 3: Regular user
let context = json!({"email": "user@company.com", "tier": "basic"});
let result = evaluator.evaluate_flag("vipFeatures", &context);
let result = evaluator.evaluate_flag("vipFeatures", context);
println!("\n3️⃣ Regular user (user@company.com, tier=basic):");
println!(
" → Result: {}, Variant: {}",
Expand Down
6 changes: 3 additions & 3 deletions python/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,17 +108,17 @@ impl FlagEvaluator {

// If we also have a flag index, use the index-based evaluation path
if let Some(&index) = self.flag_indices.get(flag_key) {
return self.inner.evaluate_flag_by_index(index, &filtered_context);
return self.inner.evaluate_flag_by_index(index, filtered_context);
}

// Otherwise use pre-enriched evaluation (context already has $flagd)
return self
.inner
.evaluate_flag_pre_enriched(flag_key, &filtered_context);
.evaluate_flag_pre_enriched(flag_key, filtered_context);
}

// Full evaluation path (no optimization data available for this flag)
self.inner.evaluate_flag(flag_key, context)
self.inner.evaluate_flag(flag_key, context.clone())
}
}

Expand Down
Loading
Loading