perf(rust): pre-compute metadata and optimize WASM binary size#115
Open
codetiger wants to merge 3 commits intoopen-feature-forking:mainfrom
Open
perf(rust): pre-compute metadata and optimize WASM binary size#115codetiger wants to merge 3 commits intoopen-feature-forking:mainfrom
codetiger wants to merge 3 commits intoopen-feature-forking:mainfrom
Conversation
…ion allocations - Pre-merge flag-set and flag-level metadata during parsing, store in Arc for cheap cloning - Use Cow<str> in resolve_string_from_context to avoid string allocations - Remove global OnceLock singleton, reuse evaluator's DataLogic engine for parsing - Use entry API and pre-allocated maps to reduce hash lookups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cozylogictoGoPlasmaticorgopt-level = "z",codegen-units = 1) — reduces WASM binary from 2.59 MB to 1.97 MB (~24% smaller)Arcfor cheap cloning, useCow<str>inresolve_string_from_contextto avoid allocations, remove globalOnceLocksingleton in favor of reusing the evaluator'sDataLogicengine, and use entry API with pre-allocated mapsTest plan
cargo test)