ci: Change actions to use global.json#418
Merged
Merged
Conversation
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
=======================================
Coverage 85.69% 85.69%
=======================================
Files 39 39
Lines 1601 1601
Branches 171 171
=======================================
Hits 1372 1372
Misses 191 191
Partials 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kriscoleman
reviewed
Apr 7, 2025
weyert
approved these changes
Apr 14, 2025
weyert
left a comment
weyert
left a comment
There was a problem hiding this comment.
Looks fine to me. As long we can keep supporting v4.6.x for now.
beeme1mr
approved these changes
Apr 14, 2025
WeihanLi
pushed a commit
to WeihanLi/openfeature-dotnet-sdk
that referenced
this pull request
May 14, 2025
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com> <!-- Please use this template for your pull request. --> <!-- Please use the sections that you need and delete other sections --> ## This PR <!-- add the description of the PR here --> This pull request includes several changes to the GitHub Actions workflows, primarily focusing on updating the .NET SDK setup and improving the release process. The most important changes are listed below: Updates to .NET SDK setup: * [`.github/workflows/ci.yml`](diffhunk://#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fL33-R33): Changed from specifying `dotnet-version` to using `global-json-file` for setting up the .NET SDK version. [[1]](diffhunk://#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fL33-R33) [[2]](diffhunk://#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fL68-R66) * [`.github/workflows/code-coverage.yml`](diffhunk://#diff-49708f979e226a1e7bd7a68d71b2e91aae8114dd3e9254d9830cd3b4d62d4303L31-R31): Updated to use `global-json-file` instead of `dotnet-version` for .NET SDK setup. * [`.github/workflows/dotnet-format.yml`](diffhunk://#diff-ca8c2611c79b991c0fbe04fec3c97c14dc83419f5efb1e8a7a96dd51e7df3e2aL20-R20): Modified to use `global-json-file` for .NET SDK setup. * [`.github/workflows/e2e.yml`](diffhunk://#diff-3e103440521ada06efd263ae09b259e5507e4b8f7408308dc227621ad9efa31eL26-R26): Changed to use `global-json-file` for setting up the .NET SDK version. * [`.github/workflows/release.yml`](diffhunk://#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34L45-R46): Updated to use `global-json-file` instead of `dotnet-version` for .NET SDK setup. [[1]](diffhunk://#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34L45-R46) [[2]](diffhunk://#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34L77-R76) Improvements to release process: * [`.github/workflows/release.yml`](diffhunk://#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34R26): Added `release-type: simple` to the release configuration. * [`.github/workflows/release.yml`](diffhunk://#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34L90-R88): Simplified the command for attaching SBOM to the release artifact. Consistency improvements: * [`.github/workflows/ci.yml`](diffhunk://#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fL7-R11): Adjusted indentation for `paths-ignore` in `push` and `pull_request` sections. ### Notes - This ensures the version used in the action is the one declared on the `global.json`. - Fixed an issue in the please-release. The release type is a mandatory field. --------- Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com> Signed-off-by: Weihan Li <weihanli@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: André Silva 2493377+askpt@users.noreply.github.com
This PR
This pull request includes several changes to the GitHub Actions workflows, primarily focusing on updating the .NET SDK setup and improving the release process. The most important changes are listed below:
Updates to .NET SDK setup:
.github/workflows/ci.yml: Changed from specifyingdotnet-versionto usingglobal-json-filefor setting up the .NET SDK version. [1] [2].github/workflows/code-coverage.yml: Updated to useglobal-json-fileinstead ofdotnet-versionfor .NET SDK setup..github/workflows/dotnet-format.yml: Modified to useglobal-json-filefor .NET SDK setup..github/workflows/e2e.yml: Changed to useglobal-json-filefor setting up the .NET SDK version..github/workflows/release.yml: Updated to useglobal-json-fileinstead ofdotnet-versionfor .NET SDK setup. [1] [2]Improvements to release process:
.github/workflows/release.yml: Addedrelease-type: simpleto the release configuration..github/workflows/release.yml: Simplified the command for attaching SBOM to the release artifact.Consistency improvements:
.github/workflows/ci.yml: Adjusted indentation forpaths-ignoreinpushandpull_requestsections.Notes
global.json.