test: Add E2E Steps for contextMerging.feature tests#422
Merged
askpt merged 8 commits intoApr 16, 2025
Conversation
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
=======================================
Coverage 85.69% 85.69%
=======================================
Files 39 39
Lines 1601 1601
Branches 171 171
=======================================
Hits 1372 1372
Misses 191 191
Partials 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kylejuliandev
changed the title
Member
|
Thanks for your contribution, @kylejuliandev.
|
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Contributor
Author
|
I've merged #395 into this branch now. Looks like CI builds pass (minus the nuget packaging due to attestations you mentioned) |
askpt
reviewed
Apr 14, 2025
Member
askpt
left a comment
askpt
left a comment
There was a problem hiding this comment.
LGTM. I only have a small suggestion about the provider initialization.
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
askpt
approved these changes
Apr 14, 2025
beeme1mr
approved these changes
Apr 14, 2025
chrfwow
requested changes
Apr 15, 2025
Contributor
chrfwow
left a comment
chrfwow
left a comment
There was a problem hiding this comment.
Looks good, but the Before Hook context needs some work
* Follow Java SDK by creating ContextStoringProvider for accessing the merged EvaluationContext * Correctly implement the BeforeHook tests * Correct naming of InitializeContext * Remove unnecessary ToString on true string Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
chrfwow
approved these changes
Apr 16, 2025
WeihanLi
pushed a commit
to WeihanLi/openfeature-dotnet-sdk
that referenced
this pull request
May 14, 2025
<!-- Please use this template for your pull request. --> <!-- Please use the sections that you need and delete other sections --> ## This PR - Add new Reqnroll steps for contextMerging.feature ahead of merging open-feature#395 ### Related Issues <!-- add here the GitHub issue that this PR resolves if applicable --> Fixes open-feature#399 ### Notes <!-- any additional notes for this PR --> I was following the [requirement 3.2.3](https://openfeature.dev/specification/sections/evaluation-context#requirement-323) I'm assuming with these additions that "Before Hook" is the same as "Invocation" in the dotnet-sdk. If this is not the case then please let me know! In order to fetch the merged context I use a test hook with a function that can set the EvaluationContext on the state. There are probably better abstractions to use I haven't updated the spec submodule in these changes either, although I can add that if needed Let me know if you have any concerns or feedback 🏗️ ### Follow-up Tasks <!-- anything that is related to this PR but not done here should be noted under this section --> <!-- if there is a need for a new issue, please link it here --> ### How to test <!-- if applicable, add testing instructions under this section --> --------- Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: André Silva <2493377+askpt@users.noreply.github.com> Signed-off-by: Weihan Li <weihanli@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #399
Notes
I was following the requirement 3.2.3
I'm assuming with these additions that "Before Hook" is the same as "Invocation" in the dotnet-sdk. If this is not the case then please let me know!
In order to fetch the merged context I use a test hook with a function that can set the EvaluationContext on the state. There are probably better abstractions to use
I haven't updated the spec submodule in these changes either, although I can add that if needed
Let me know if you have any concerns or feedback 🏗️
Follow-up Tasks
How to test