ci: Remove artifact attestation step from workflow#425
Merged
Conversation
Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
=======================================
Coverage 85.71% 85.71%
=======================================
Files 39 39
Lines 1603 1603
Branches 171 171
=======================================
Hits 1374 1374
Misses 191 191
Partials 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kylejuliandev
approved these changes
Apr 12, 2025
weyert
approved these changes
Apr 14, 2025
weyert
left a comment
weyert
left a comment
There was a problem hiding this comment.
LGTM. My understanding we just remove it for the workflows ran as part of a PR but still do it for the actual nuget publications
Member
Author
Exactly @weyert! We don't need to do it on PR because it will block forks from being merged also. |
beeme1mr
approved these changes
Apr 14, 2025
WeihanLi
pushed a commit
to WeihanLi/openfeature-dotnet-sdk
that referenced
this pull request
May 14, 2025
<!-- Please use this template for your pull request. --> <!-- Please use the sections that you need and delete other sections --> ## This PR <!-- add the description of the PR here --> This pull request includes a small change to the `.github/workflows/ci.yml` file. The change removes the step that generates artifact attestation using the `actions/attest-build-provenance` action. * Removed the `Generate artifact attestation` step from the CI workflow in `.github/workflows/ci.yml`. ### Related Issues <!-- add here the GitHub issue that this PR resolves if applicable --> Fixes open-feature#423 ### Notes <!-- any additional notes for this PR --> This only removes execution from the PRs and forks. It will not be removed from the main publishing action. Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com> Signed-off-by: Weihan Li <weihanli@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
This pull request includes a small change to the
.github/workflows/ci.ymlfile. The change removes the step that generates artifact attestation using theactions/attest-build-provenanceaction.Generate artifact attestationstep from the CI workflow in.github/workflows/ci.yml.Related Issues
Fixes #423
Notes
This only removes execution from the PRs and forks. It will not be removed from the main publishing action.