Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/OpenFeature/Hooks/MetricsHook.cs
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@ public override ValueTask AfterAsync<T>(HookContext<T> context, FlagEvaluationDe
{ TelemetryConstants.Reason, details.Reason ?? Reason.Unknown.ToString() }
};

if (details.Variant != null)
{
tagList.Add(TelemetryConstants.Variant, details.Variant);
}

this.AddCustomDimensions(ref tagList);
this.AddFlagMetadataDimensions(details.FlagMetadata, ref tagList);

Expand Down
29 changes: 29 additions & 0 deletions test/OpenFeature.Tests/Hooks/MetricsHookTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,35 @@ await metricsHook.AfterAsync(ctx,
Assert.Equal("my-flag", measurements.Tags["feature_flag.key"]);
Assert.Equal("my-provider", measurements.Tags["feature_flag.provider.name"]);
Assert.Equal("STATIC", measurements.Tags["feature_flag.result.reason"]);
Assert.Equal("default", measurements.Tags["feature_flag.result.variant"]);
}

[Fact]
public async Task Without_Variant_After_Test_Does_Not_Include_Variant()
{
// Arrange
var metricsHook = new MetricsHook();

using var collector = new MetricCollector<long>(metricsHook._evaluationSuccessCounter);

var evaluationContext = EvaluationContext.Empty;
var ctx = new HookContext<string>("my-flag", "foo", Constant.FlagValueType.String,
new ClientMetadata("my-client", "1.0"), new Metadata("my-provider"), evaluationContext);

// Act
await metricsHook.AfterAsync(ctx,
new FlagEvaluationDetails<string>("my-flag", "foo", Constant.ErrorType.None, "STATIC", variant: null),
new Dictionary<string, object>()).ConfigureAwait(true);

var measurements = collector.LastMeasurement;

// Assert
Assert.NotNull(measurements);

Assert.Equal("my-flag", measurements.Tags["feature_flag.key"]);
Assert.Equal("my-provider", measurements.Tags["feature_flag.provider.name"]);
Assert.Equal("STATIC", measurements.Tags["feature_flag.result.reason"]);
Assert.DoesNotContain("feature_flag.result.variant", measurements.Tags.Keys);
}

[Fact]
Expand Down
Loading