chore: resolve open dependabot security alerts#41
Conversation
- ws 8.18.0 -> 8.21.0 (high, alert #54) via bumping wrangler to ^4.112.0 and @cloudflare/vitest-pool-workers to ^0.18.6, which pull in a patched miniflare release - Bumped @cloudflare/workers-types to ^5.20260719.1 to match the newer workerd runtime types pulled in transitively - Updated examples/js-worker/src/index.ts to import Hono's own ExecutionContext type explicitly, since the newer @cloudflare/workers-types now requires a `tracing` field on the global ExecutionContext type that Hono's context object does not provide Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR resolves an open Dependabot security alert by updating the examples/js-worker toolchain dependencies so that miniflare pulls in a patched ws version, and adjusts TypeScript typing to remain compatible with the newer Cloudflare Workers type definitions.
Changes:
- Bumped
wranglerand@cloudflare/vitest-pool-workers(and updated the lockfile), resulting inminiflaredepending onws@8.21.0instead of8.18.0. - Bumped
@cloudflare/workers-typesin theexamples/js-workerworkspace to match the newer runtime/tooling types. - Updated
examples/js-worker/src/index.tsto use Hono’sExecutionContexttype explicitly to avoid incompatibility with the newer globalExecutionContexttyping.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package-lock.json | Locks updated dependency graph reflecting the wrangler/miniflare updates and the patched ws version. |
| examples/js-worker/package.json | Bumps devDependencies to versions that address the ws vulnerability and align Workers types. |
| examples/js-worker/src/index.ts | Imports and uses Hono’s ExecutionContext type to keep typechecking compatible with updated @cloudflare/workers-types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Dependabot Alerts Resolved
wswrangler(^4.61.0->^4.112.0) and@cloudflare/vitest-pool-workers(^0.15.1->^0.18.6) inexamples/js-worker, both of which now pull in aminiflarerelease that depends on the patchedws@8.21.0instead of the vulnerable8.18.0(GHSA-96hv-2xvq-fx4p, memory exhaustion DoS from tiny fragments/data chunks)Additional changes required to keep the build green
@cloudflare/workers-types(^4.20260127.0->^5.20260719.1) to match the newerworkerdruntime types pulled in by the updatedwrangler/miniflare@cloudflare/workers-typesmakes thetracingfield on the globalExecutionContexttype required, which is incompatible with Hono's own (older-shaped)ExecutionContexttype returned byc.executionCtx. Fixed by explicitly importing and using Hono'sExecutionContexttype inexamples/js-worker/src/index.tsinstead of relying on the ambient global type — no runtime behavior change.