fix: web and cli docs do not mention s3 (#1941)

See title.

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

Author: toddbaert

core/pkg/sync/builder/syncbuilder.go

@@ -268,7 +268,7 @@ func (sb *SyncBuilder) newAzblob(config sync.SourceConfig, logger *logger.Logger
 
 func (sb *SyncBuilder) newS3(config sync.SourceConfig, logger *logger.Logger) *blobSync.Sync {
 	// Extract bucket uri and object name from the full URI:
-	// gs://bucket/path/to/object results in gs://bucket/ as bucketUri and
+	// s3://bucket/path/to/object results in s3://bucket/ as bucketUri and
 	// path/to/object as an object name.
 	bucketURI := regS3.FindString(config.URI)
 	objectName := regS3.ReplaceAllString(config.URI, "")

core/pkg/sync/builder/utils.go

@@ -81,7 +81,7 @@ func ParseSyncProviderURIs(uris []string) ([]sync.SourceConfig, error) {
 			})
 		default:
 			return syncProvidersParsed, fmt.Errorf("invalid sync uri argument: %s, must start with 'file:', "+
-				"'http(s)://', 'grpc(s)://', 'gs://', 'azblob://' or 'core.openfeature.dev'", uri)
+				"'http(s)://', 'grpc(s)://', 'gs://', 'azblob://', 's3://' or 'core.openfeature.dev'", uri)
 		}
 	}
 	return syncProvidersParsed, nil

docs/reference/flagd-cli/flagd_start.md

@@ -35,7 +35,7 @@ flagd start [flags]
       --stream-deadline duration             Set a server-side deadline for flagd sync and event streams (default 0, means no deadline).
   -g, --sync-port int32                      gRPC Sync port (default 8015)
   -e, --sync-socket-path string              Flagd sync service socket path. With grpc the sync service will be available on this address.
-  -f, --uri .yaml/.yml/.json                 Set a sync provider uri to read data from, this can be a filepath, URL (HTTP and gRPC), FeatureFlag custom resource, or GCS or Azure Blob. When flag keys are duplicated across multiple providers the merge priority follows the index of the flag arguments, as such flags from the uri at index 0 take the lowest precedence, with duplicated keys being overwritten by those from the uri at index 1. Please note that if you are using filepath, flagd only supports files with .yaml/.yml/.json extension.
+  -f, --uri .yaml/.yml/.json                 Set a sync provider uri to read data from, this can be a filepath, URL (HTTP and gRPC), FeatureFlag custom resource, or GCS, Azure Blob or S3. When flag keys are duplicated across multiple providers the merge priority follows the index of the flag arguments, as such flags from the uri at index 0 take the lowest precedence, with duplicated keys being overwritten by those from the uri at index 1. Please note that if you are using filepath, flagd only supports files with .yaml/.yml/.json extension.
 ```
 
 ### Options inherited from parent commands

docs/reference/sync-configuration.md

@@ -50,9 +50,9 @@ Alternatively, these configurations can be passed to flagd via config file, spec
 | Field              | Type               | Note                                                                                                                                                                                                                                                                                                      |
 | ------------------ | ------------------ | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
 | uri                | required `string`  | Flag configuration source of the sync                                                                                                                                                                                                                                                                     |
-| provider           | required `string`  | Provider type - `file`, `fsnotify`, `fileinfo`, `kubernetes`, `http`, `grpc`, `gcs` or `azblob`                                                                                                                                                                                                           |
+| provider           | required `string`  | Provider type - `file`, `fsnotify`, `fileinfo`, `kubernetes`, `http`, `grpc`, `gcs`, `azblob` or `s3`                                                                                                                                                                                                           |
 | authHeader         | optional `string`  | Used for http sync; set this to include the complete `Authorization` header value for any authentication scheme (e.g., "Bearer token_here", "Basic base64_credentials", etc.).                                                                                                                            |
-| interval           | optional `uint32`  | Used for http, gcs and azblob syncs; requests will be made at this interval. Defaults to 5 seconds.                                                                                                                                                                                                       |
+| interval           | optional `uint32`  | Used for http, gcs, azblob and s3 syncs; requests will be made at this interval. Defaults to 5 seconds.                                                                                                                                                                                                       |
 | tls                | optional `boolean` | Enable/Disable secure TLS connectivity. Currently used only by gRPC sync. Default (ex: if unset) is false, which will use an insecure connection                                                                                                                                                          |
 | providerID         | optional `string`  | Value binds to grpc connection's providerID field. gRPC server implementations may use this to identify connecting flagd instance                                                                                                                                                                         |
 | selector           | optional `string`  | Selector expression to filter flag configurations. Supports `source=<name>` and `flagSetId=<id>` syntax. See [selector syntax](selector-syntax.md) for details.                                                                                                                                           |
@@ -86,6 +86,7 @@ Sync providers:
 - `grpc`(envoy) - envoy://localhost:9211/test.service
 - `gcs` - gs://my-bucket/my-flags.json
 - `azblob` - azblob://my-container/my-flags.json
+- `s3` - s3://my-bucket/my-flags.json
 
 Startup command:
 
@@ -103,7 +104,8 @@ Startup command:
             {"uri":"envoy://localhost:9211/test.service", "provider":"grpc"},
             {"uri":"my-flag-source:8080","provider":"grpc", "certPath": "/certs/ca.cert", "tls": true, "providerID": "flagd-weatherapp-sidecar", "selector": "flagSetId=weatherapp"},
             {"uri":"gs://my-bucket/my-flag.json","provider":"gcs"},
-            {"uri":"azblob://my-container/my-flag.json","provider":"azblob"}]'
+            {"uri":"azblob://my-container/my-flag.json","provider":"azblob"},
+            {"uri":"s3://my-bucket/my-flag.json","provider":"s3"}]'
 ```
 
 Configuration file,
@@ -138,6 +140,8 @@ sources:
     provider: gcs
   - uri: azblob://my-container/my-flags.json
     provider: azblob
+  - uri: s3://my-bucket/my-flags.json
+    provider: s3
 ```
 
 ### HTTP Configuration

flagd/cmd/start.go

@@ -64,7 +64,7 @@ func init() {
 	flags.StringP(serverKeyPathFlagName, "k", "", "Server side tls key path")
 	flags.StringSliceP(
 		uriFlagName, "f", []string{}, "Set a sync provider uri to read data from, this can be a filepath,"+
-			" URL (HTTP and gRPC), FeatureFlag custom resource, or GCS or Azure Blob. "+
+			" URL (HTTP and gRPC), FeatureFlag custom resource, or GCS, Azure Blob or S3. "+
 			"When flag keys are duplicated across multiple providers the "+
 			"merge priority follows the index of the flag arguments, as such flags from the uri at index 0 take the "+
 			"lowest precedence, with duplicated keys being overwritten by those from the uri at index 1. "+