Skip to content

Commit ab05761

Browse files
committed
docs: address review feedback on disabled flag ADR
- Clarify variant/value omission semantics across languages - Rename Timeline to Implementation steps grouped by phase - Add Versioning and migration section - Resolve open questions on dashboards, versioning, and FlagDisabledErrorCode removal - Fix MD029 ordered list numbering Signed-off-by: Parth Suthar <parth.suthar@dynatrace.com>
1 parent 2053000 commit ab05761

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

docs/architecture-decisions/disabled-flag-evaluation.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -263,13 +263,13 @@ The work breaks down into three groups that must land together for a coherent re
263263

264264
**Ecosystem (rolled out alongside or shortly after the flagd core release):**
265265

266-
7. Update each language SDK's in-process provider evaluator to return `reason=DISABLED` with code-default deferral instead of raising an error when encountering a disabled flag.
267-
8. Update OpenFeature providers (RPC and in-process) to recognize `DISABLED` as a non-error, non-cacheable reason.
266+
1. Update each language SDK's in-process provider evaluator to return `reason=DISABLED` with code-default deferral instead of raising an error when encountering a disabled flag.
267+
2. Update OpenFeature providers (RPC and in-process) to recognize `DISABLED` as a non-error, non-cacheable reason.
268268

269269
**Validation and documentation:**
270270

271-
9. Update flagd-testbed with test cases for disabled flag evaluation across all surfaces (gRPC v1, gRPC v2, OFREP single, OFREP bulk, in-process).
272-
10. Update provider documentation and call out the behavior change prominently in the flagd release notes.
271+
1. Update flagd-testbed with test cases for disabled flag evaluation across all surfaces (gRPC v1, gRPC v2, OFREP single, OFREP bulk, in-process).
272+
2. Update provider documentation and call out the behavior change prominently in the flagd release notes.
273273

274274
### Open questions
275275

0 commit comments

Comments
 (0)