Fix review comments1. setup.sh was updating parameter manager instead of creating new versoin2. locationId default to prevent null pointers3. update references to stale GcpParameterManagerOptions

Signed-off-by: Mahesh Patil <maheshfinity@gmail.com>

Author: mahpatil

providers/gcp/src/main/java/dev/openfeature/contrib/providers/gcp/GcpParameterManagerProvider.java

@@ -91,10 +91,8 @@ public void shutdown() {
     @Override
     protected String fetchFromGcp(String parameterName) {
         try {
-            log.info("Fetching parameter from GCP name '{}'", parameterName);
             ParameterVersionName versionName = ParameterVersionName.of(
                     options.getProjectId(), options.getLocationId(), parameterName, options.getVersion());
-            log.info("Fetching parameter from GCP version {}", parameterName);
             RenderParameterVersionResponse response = client.renderParameterVersion(versionName);
             return response.getRenderedPayload().toStringUtf8();
         } catch (NotFoundException e) {

providers/gcp/src/main/java/dev/openfeature/contrib/providers/gcp/GcpProviderOptions.java

@@ -45,7 +45,7 @@ public class GcpProviderOptions {
     /**
      * Optional location required for ParameterManager, ignored by SecretManager
      */
-    private final String locationId;
+    private final String locationId = "global";
 
     /**
      * How long a fetched secret value is retained in the in-memory cache before

samples/gcp/setup.sh

@@ -50,12 +50,12 @@ create_entry() {
     elif [[ "$BACKEND" == "parameter-manager" ]]; then
         # Create or update Parameter Manager parameter
         if gcloud parametermanager parameters describe "${full_name}" --location=global --project="${PROJECT}" &>/dev/null 2>&1; then
-            echo "  [EXISTS] ${full_name} — updating value"
-            gcloud parametermanager parameters update "${full_name}" \
-                --location=global \
+            echo "  [EXISTS] ${full_name} — create new version"
+            gcloud parametermanager parameters versions create VERSION_ID \
+                --parameter="${full_name}" \
                 --project="${PROJECT}" \
-                --data="${value}" \
-                --quiet || echo "  [WARN] Could not update parameter (may require gcloud alpha components)"
+                --location=global \
+                --payload-data="${value}"
         else
             gcloud parametermanager parameters create "${full_name}" \
                 --location=global \