chore: add deploy profile to ci; catches pkging issues

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

Author: toddbaert

.github/workflows/ci.yml

@@ -16,8 +16,11 @@ jobs:
           build:
               - java: 21
                 profile: codequality
+                # the deploy profile pulls in plugins (exists-maven-plugin, javadoc, cyclonedx, source) that require Java 17+; only enable on the Java 21 build
+                extra_profiles: ',deploy'
               - java: 11
                 profile: java11
+                extra_profiles: ''
 
     name: with Java ${{ matrix.build.java }}
     runs-on: ${{ matrix.os}}
@@ -43,5 +46,6 @@ jobs:
             ${{ runner.os }}${{ matrix.build.java }}-maven-
 
       - name: Maven Verify
-        # Run Maven build with e2e and specific profile, using parallel threads (if some provider decides to use a different toolchain version, this might break)
-        run: mvn -T 2C --batch-mode --activate-profiles e2e,${{ matrix.build.profile }} clean verify
+        # Run Maven build with e2e and specific profile, using parallel threads (if some provider decides to use a different toolchain version, this might break).
+        # On Java 21, the deploy profile is also activated to catch javadoc/SBOM/source-jar issues at PR time; verify never reaches install/deploy phases so nothing is published.
+        run: mvn -T 2C --batch-mode --activate-profiles e2e,${{ matrix.build.profile }}${{ matrix.build.extra_profiles }} clean verify

providers/gcp/src/main/java/dev/openfeature/contrib/providers/gcp/GcpSecretManagerProvider.java

@@ -20,7 +20,7 @@
  *
  * <p>Each feature flag is stored as an individual secret in GCP Secret Manager. The flag key
  * maps directly to the secret name (with an optional prefix configured via
- * {@link GcpProviderOptions#getNamePrefix()}).
+ * {@link GcpProviderOptions}'s {@code namePrefix}).
  *
  * <p>Flag values are read as UTF-8 strings from the secret payload and parsed to the requested
  * type. Supported raw value formats:
@@ -33,7 +33,7 @@
  * </ul>
  *
  * <p>Results are cached in-process for the duration configured in
- * {@link GcpProviderOptions#getCacheExpiry()}.
+ * {@link GcpProviderOptions}'s {@code cacheExpiry}.
  *
  * <p>Example:
  * <pre>{@code