Skip to content

Commit ea9a5f1

Browse files
committed
chore: add deploy profile to ci; catches pkging issues
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
1 parent b6a90fb commit ea9a5f1

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,5 +43,6 @@ jobs:
4343
${{ runner.os }}${{ matrix.build.java }}-maven-
4444
4545
- name: Maven Verify
46-
# Run Maven build with e2e and specific profile, using parallel threads (if some provider decides to use a different toolchain version, this might break)
47-
run: mvn -T 2C --batch-mode --activate-profiles e2e,${{ matrix.build.profile }} clean verify
46+
# Run Maven build with e2e and specific profile, using parallel threads (if some provider decides to use a different toolchain version, this might break).
47+
# The deploy profile is activated to catch javadoc/SBOM/source-jar issues at PR time; verify never reaches install/deploy phases so nothing is published.
48+
run: mvn -T 2C --batch-mode --activate-profiles deploy,e2e,${{ matrix.build.profile }} clean verify

providers/gcp/src/main/java/dev/openfeature/contrib/providers/gcp/GcpSecretManagerProvider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
*
2121
* <p>Each feature flag is stored as an individual secret in GCP Secret Manager. The flag key
2222
* maps directly to the secret name (with an optional prefix configured via
23-
* {@link GcpProviderOptions#getNamePrefix()}).
23+
* {@link GcpProviderOptions}'s {@code namePrefix}).
2424
*
2525
* <p>Flag values are read as UTF-8 strings from the secret payload and parsed to the requested
2626
* type. Supported raw value formats:
@@ -33,7 +33,7 @@
3333
* </ul>
3434
*
3535
* <p>Results are cached in-process for the duration configured in
36-
* {@link GcpProviderOptions#getCacheExpiry()}.
36+
* {@link GcpProviderOptions}'s {@code cacheExpiry}.
3737
*
3838
* <p>Example:
3939
* <pre>{@code

0 commit comments

Comments
 (0)