Skip to content

Commit ed2e042

Browse files
authored
chore: add deploy profile to ci; catches pkging issues (#1804)
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
1 parent b6a90fb commit ed2e042

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

.github/workflows/ci.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,9 @@ jobs:
1515
os: [ubuntu-latest]
1616
build:
1717
- java: 21
18-
profile: codequality
18+
# deploy profile is included to catch javadoc/SBOM/source-jar issues at PR time
19+
# note this is the publish PROFILE, not PHASE
20+
profile: codequality,deploy
1921
- java: 11
2022
profile: java11
2123

providers/gcp/src/main/java/dev/openfeature/contrib/providers/gcp/GcpSecretManagerProvider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
*
2121
* <p>Each feature flag is stored as an individual secret in GCP Secret Manager. The flag key
2222
* maps directly to the secret name (with an optional prefix configured via
23-
* {@link GcpProviderOptions#getNamePrefix()}).
23+
* {@link GcpProviderOptions}'s {@code namePrefix}).
2424
*
2525
* <p>Flag values are read as UTF-8 strings from the secret payload and parsed to the requested
2626
* type. Supported raw value formats:
@@ -33,7 +33,7 @@
3333
* </ul>
3434
*
3535
* <p>Results are cached in-process for the duration configured in
36-
* {@link GcpProviderOptions#getCacheExpiry()}.
36+
* {@link GcpProviderOptions}'s {@code cacheExpiry}.
3737
*
3838
* <p>Example:
3939
* <pre>{@code

0 commit comments

Comments
 (0)