Skip to content

chore: add deploy profile to ci; catches pkging issues #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toddbaert merged 1 commit into from
Jun 3, 2026
Merged

chore: add deploy profile to ci; catches pkging issues #1804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ jobs:
os: [ubuntu-latest]
build:
- java: 21
profile: codequality
# deploy profile is included to catch javadoc/SBOM/source-jar issues at PR time
# note this is the publish PROFILE, not PHASE
profile: codequality,deploy
- java: 11
profile: java11

Expand Down
4 changes: 2 additions & 2 deletions ...ers/gcp/src/main/java/dev/openfeature/contrib/providers/gcp/GcpSecretManagerProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
*
* <p>Each feature flag is stored as an individual secret in GCP Secret Manager. The flag key
* maps directly to the secret name (with an optional prefix configured via
* {@link GcpProviderOptions#getNamePrefix()}).
* {@link GcpProviderOptions}'s {@code namePrefix}).
*
* <p>Flag values are read as UTF-8 strings from the secret payload and parsed to the requested
* type. Supported raw value formats:
Expand All @@ -33,7 +33,7 @@
* </ul>
*
* <p>Results are cached in-process for the duration configured in
* {@link GcpProviderOptions#getCacheExpiry()}.
* {@link GcpProviderOptions}'s {@code cacheExpiry}.
*
* <p>Example:
* <pre>{@code
Expand Down
Loading