fixup: remove OpenFeatureAPIFactory class per review consensus

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

Author: toddbaert

src/main/java/dev/openfeature/sdk/OpenFeatureAPI.java

@@ -22,7 +22,7 @@
  * there is shared across all {@link Client}s. For dependency-injection frameworks, testing, or
  * multi-tenant scenarios that need fully independent state (providers, hooks, evaluation context,
  * event handlers, transaction context propagators), create isolated instances via
- * {@code dev.openfeature.sdk.isolated.OpenFeatureAPIFactory.createAPI()}.
+ * {@link #createIsolated()}.
  *
  * <p><strong>Note:</strong> Isolated API instances (per spec section 1.8) are experimental and
  * subject to change.
@@ -55,10 +55,6 @@ public class OpenFeatureAPI implements EventBus<OpenFeatureAPI> {
      * state (providers, hooks, evaluation context, event handlers, transaction context
      * propagators).
      *
-     * <p>Prefer {@code OpenFeatureAPIFactory.createAPI()} from
-     * {@code dev.openfeature.sdk.isolated}, which satisfies spec requirement 1.8.3
-     * (factory in a distinct package for intentional discoverability).
-     *
      * @apiNote This API is experimental and subject to change.
      * @see <a href="https://openfeature.dev/specification/sections/flag-evaluation#18-isolated-api-instances">
      *     Spec &sect;1.8 &mdash; Isolated API Instances</a>
@@ -67,7 +63,7 @@ public static OpenFeatureAPI createIsolated() {
         return new OpenFeatureAPI();
     }
 
-    // Package-private: not part of the public API; use createIsolated() or OpenFeatureAPIFactory.
+    // Package-private: not part of the public API; use createIsolated().
     OpenFeatureAPI() {
         this(new AutoCloseableReentrantReadWriteLock());
     }

src/main/java/dev/openfeature/sdk/isolated/OpenFeatureAPIFactory.java

@@ -7,7 +7,6 @@
 import dev.openfeature.sdk.NoOpTransactionContextPropagator;
 import dev.openfeature.sdk.OpenFeatureAPI;
 import dev.openfeature.sdk.ThreadLocalTransactionContextPropagator;
-import dev.openfeature.sdk.isolated.OpenFeatureAPIFactory;
 import dev.openfeature.sdk.providers.memory.InMemoryProvider;
 import java.util.Map;
 import org.junit.jupiter.api.AfterEach;
@@ -36,7 +35,7 @@ void isolatedInstanceDoesNotInterfereWithSingleton() {
         // record singleton baseline
         FeatureProvider singletonProvider = singleton.getProvider();
 
-        OpenFeatureAPI isolated = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI isolated = OpenFeatureAPI.createIsolated();
         assertThat(isolated).isNotSameAs(singleton);
 
         // mutate only the isolated instance
@@ -57,7 +56,7 @@ void isolatedInstanceDoesNotInterfereWithSingleton() {
     @Test
     @DisplayName("singleton does not interfere with isolated instance")
     void singletonDoesNotInterfereWithIsolatedInstance() {
-        OpenFeatureAPI isolated = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI isolated = OpenFeatureAPI.createIsolated();
 
         // record isolated baseline
         FeatureProvider isolatedProvider = isolated.getProvider();

src/test/java/dev/openfeature/sdk/isolated/IsolatedAPISingeltonTest.java

@@ -8,7 +8,6 @@
 import dev.openfeature.sdk.NoOpTransactionContextPropagator;
 import dev.openfeature.sdk.OpenFeatureAPI;
 import dev.openfeature.sdk.ThreadLocalTransactionContextPropagator;
-import dev.openfeature.sdk.isolated.OpenFeatureAPIFactory;
 import dev.openfeature.sdk.providers.memory.Flag;
 import dev.openfeature.sdk.providers.memory.InMemoryProvider;
 import java.util.Map;
@@ -31,8 +30,8 @@ class IsolatedAPITest {
     @Test
     @DisplayName("factory creates distinct API instances")
     void factoryCreatesDistinctInstances() {
-        OpenFeatureAPI api1 = OpenFeatureAPIFactory.createAPI();
-        OpenFeatureAPI api2 = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI api1 = OpenFeatureAPI.createIsolated();
+        OpenFeatureAPI api2 = OpenFeatureAPI.createIsolated();
 
         assertThat(api1).isInstanceOf(OpenFeatureAPI.class).isNotSameAs(api2);
     }
@@ -43,8 +42,8 @@ void factoryCreatesDistinctInstances() {
     @Test
     @DisplayName("providers are isolated between instances")
     void providerIsolation() {
-        OpenFeatureAPI api1 = OpenFeatureAPIFactory.createAPI();
-        OpenFeatureAPI api2 = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI api1 = OpenFeatureAPI.createIsolated();
+        OpenFeatureAPI api2 = OpenFeatureAPI.createIsolated();
 
         InMemoryProvider provider = new InMemoryProvider(Map.of());
         api1.setProvider(provider);
@@ -59,8 +58,8 @@ void providerIsolation() {
     @Test
     @DisplayName("hooks are isolated between instances")
     void hookIsolation() {
-        OpenFeatureAPI api1 = OpenFeatureAPIFactory.createAPI();
-        OpenFeatureAPI api2 = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI api1 = OpenFeatureAPI.createIsolated();
+        OpenFeatureAPI api2 = OpenFeatureAPI.createIsolated();
 
         api1.addHooks(new NoOpHook());
 
@@ -74,8 +73,8 @@ void hookIsolation() {
     @Test
     @DisplayName("evaluation context is isolated between instances")
     void evaluationContextIsolation() {
-        OpenFeatureAPI api1 = OpenFeatureAPIFactory.createAPI();
-        OpenFeatureAPI api2 = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI api1 = OpenFeatureAPI.createIsolated();
+        OpenFeatureAPI api2 = OpenFeatureAPI.createIsolated();
 
         api1.setEvaluationContext(new ImmutableContext("key-1"));
         api2.setEvaluationContext(new ImmutableContext("key-2"));
@@ -91,8 +90,8 @@ void evaluationContextIsolation() {
     @Timeout(value = 2, threadMode = Timeout.ThreadMode.SEPARATE_THREAD)
     @DisplayName("event handlers are isolated between instances")
     void eventHandlerIsolation() throws Exception {
-        OpenFeatureAPI api1 = OpenFeatureAPIFactory.createAPI();
-        OpenFeatureAPI api2 = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI api1 = OpenFeatureAPI.createIsolated();
+        OpenFeatureAPI api2 = OpenFeatureAPI.createIsolated();
 
         CountDownLatch api1HandlerLatch = new CountDownLatch(1);
         AtomicBoolean api2HandlerCalled = new AtomicBoolean(false);
@@ -120,8 +119,8 @@ void eventHandlerIsolation() throws Exception {
     @Test
     @DisplayName("transaction context propagator is isolated between instances")
     void transactionContextPropagatorIsolation() {
-        OpenFeatureAPI api1 = OpenFeatureAPIFactory.createAPI();
-        OpenFeatureAPI api2 = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI api1 = OpenFeatureAPI.createIsolated();
+        OpenFeatureAPI api2 = OpenFeatureAPI.createIsolated();
 
         ThreadLocalTransactionContextPropagator propagator = new ThreadLocalTransactionContextPropagator();
         api1.setTransactionContextPropagator(propagator);
@@ -137,7 +136,7 @@ void transactionContextPropagatorIsolation() {
     @Test
     @DisplayName("isolated instance conforms to API contract")
     void isolatedInstanceConformsToAPIContract() throws Exception {
-        OpenFeatureAPI api = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI api = OpenFeatureAPI.createIsolated();
 
         // provider management
         InMemoryProvider provider = new InMemoryProvider(Map.of(
@@ -172,8 +171,8 @@ void isolatedInstanceConformsToAPIContract() throws Exception {
     @Test
     @DisplayName("clearHooks does not affect other instances")
     void clearHooksDoesNotAffectOtherInstances() {
-        OpenFeatureAPI api1 = OpenFeatureAPIFactory.createAPI();
-        OpenFeatureAPI api2 = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI api1 = OpenFeatureAPI.createIsolated();
+        OpenFeatureAPI api2 = OpenFeatureAPI.createIsolated();
 
         NoOpHook hook = new NoOpHook();
         api1.addHooks(hook);
@@ -192,8 +191,8 @@ void clearHooksDoesNotAffectOtherInstances() {
     @Test
     @DisplayName("clients use their own instance's provider")
     void clientUsesItsOwnInstanceProvider() throws Exception {
-        OpenFeatureAPI api1 = OpenFeatureAPIFactory.createAPI();
-        OpenFeatureAPI api2 = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI api1 = OpenFeatureAPI.createIsolated();
+        OpenFeatureAPI api2 = OpenFeatureAPI.createIsolated();
 
         api1.setProviderAndWait(new InMemoryProvider(Map.of(
                 "flag1",
@@ -221,8 +220,8 @@ void warnWhenProviderBoundToMultipleInstances() {
         Logger mockLogger = Mockito.mock(Logger.class);
         LoggerMock.setMock(OpenFeatureAPI.class, mockLogger);
         try {
-            OpenFeatureAPI api1 = OpenFeatureAPIFactory.createAPI();
-            OpenFeatureAPI api2 = OpenFeatureAPIFactory.createAPI();
+            OpenFeatureAPI api1 = OpenFeatureAPI.createIsolated();
+            OpenFeatureAPI api2 = OpenFeatureAPI.createIsolated();
 
             NoOpProvider provider = new NoOpProvider();
             api1.setProvider(provider);