test: use direct constructor in isolated tests

Signed-off-by: marcozabel <marco.zabel@dynatrace.com>

Author: marcozabel

src/test/java/dev/openfeature/sdk/isolated/IsolatedAPISingeltonTest.java

@@ -35,7 +35,7 @@ void isolatedInstanceDoesNotInterfereWithSingleton() {
         // record singleton baseline
         FeatureProvider singletonProvider = singleton.getProvider();
 
-        OpenFeatureAPI isolated = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI isolated = new OpenFeatureAPI();
         assertThat(isolated).isNotSameAs(singleton);
 
         // mutate only the isolated instance
@@ -56,7 +56,7 @@ void isolatedInstanceDoesNotInterfereWithSingleton() {
     @Test
     @DisplayName("singleton does not interfere with isolated instance")
     void singletonDoesNotInterfereWithIsolatedInstance() {
-        OpenFeatureAPI isolated = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI isolated = new OpenFeatureAPI();
 
         // record isolated baseline
         FeatureProvider isolatedProvider = isolated.getProvider();

src/test/java/dev/openfeature/sdk/isolated/IsolatedAPITest.java

@@ -30,8 +30,8 @@ class IsolatedAPITest {
     @Test
     @DisplayName("factory creates distinct API instances")
     void factoryCreatesDistinctInstances() {
-        OpenFeatureAPI api1 = OpenFeatureAPIFactory.createAPI();
-        OpenFeatureAPI api2 = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI api1 = new OpenFeatureAPI();
+        OpenFeatureAPI api2 = new OpenFeatureAPI();
 
         assertThat(api1).isInstanceOf(OpenFeatureAPI.class).isNotSameAs(api2);
     }
@@ -42,8 +42,8 @@ void factoryCreatesDistinctInstances() {
     @Test
     @DisplayName("providers are isolated between instances")
     void providerIsolation() {
-        OpenFeatureAPI api1 = OpenFeatureAPIFactory.createAPI();
-        OpenFeatureAPI api2 = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI api1 = new OpenFeatureAPI();
+        OpenFeatureAPI api2 = new OpenFeatureAPI();
 
         InMemoryProvider provider = new InMemoryProvider(Map.of());
         api1.setProvider(provider);
@@ -58,8 +58,8 @@ void providerIsolation() {
     @Test
     @DisplayName("hooks are isolated between instances")
     void hookIsolation() {
-        OpenFeatureAPI api1 = OpenFeatureAPIFactory.createAPI();
-        OpenFeatureAPI api2 = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI api1 = new OpenFeatureAPI();
+        OpenFeatureAPI api2 = new OpenFeatureAPI();
 
         api1.addHooks(new NoOpHook());
 
@@ -73,8 +73,8 @@ void hookIsolation() {
     @Test
     @DisplayName("evaluation context is isolated between instances")
     void evaluationContextIsolation() {
-        OpenFeatureAPI api1 = OpenFeatureAPIFactory.createAPI();
-        OpenFeatureAPI api2 = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI api1 = new OpenFeatureAPI();
+        OpenFeatureAPI api2 = new OpenFeatureAPI();
 
         api1.setEvaluationContext(new ImmutableContext("key-1"));
         api2.setEvaluationContext(new ImmutableContext("key-2"));
@@ -90,8 +90,8 @@ void evaluationContextIsolation() {
     @Timeout(value = 2, threadMode = Timeout.ThreadMode.SEPARATE_THREAD)
     @DisplayName("event handlers are isolated between instances")
     void eventHandlerIsolation() throws Exception {
-        OpenFeatureAPI api1 = OpenFeatureAPIFactory.createAPI();
-        OpenFeatureAPI api2 = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI api1 = new OpenFeatureAPI();
+        OpenFeatureAPI api2 = new OpenFeatureAPI();
 
         CountDownLatch api1HandlerLatch = new CountDownLatch(1);
         AtomicBoolean api2HandlerCalled = new AtomicBoolean(false);
@@ -119,8 +119,8 @@ void eventHandlerIsolation() throws Exception {
     @Test
     @DisplayName("transaction context propagator is isolated between instances")
     void transactionContextPropagatorIsolation() {
-        OpenFeatureAPI api1 = OpenFeatureAPIFactory.createAPI();
-        OpenFeatureAPI api2 = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI api1 = new OpenFeatureAPI();
+        OpenFeatureAPI api2 = new OpenFeatureAPI();
 
         ThreadLocalTransactionContextPropagator propagator = new ThreadLocalTransactionContextPropagator();
         api1.setTransactionContextPropagator(propagator);
@@ -136,7 +136,7 @@ void transactionContextPropagatorIsolation() {
     @Test
     @DisplayName("isolated instance conforms to API contract")
     void isolatedInstanceConformsToAPIContract() throws Exception {
-        OpenFeatureAPI api = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI api = new OpenFeatureAPI();
 
         // provider management
         InMemoryProvider provider = new InMemoryProvider(Map.of(
@@ -171,8 +171,8 @@ void isolatedInstanceConformsToAPIContract() throws Exception {
     @Test
     @DisplayName("clearHooks does not affect other instances")
     void clearHooksDoesNotAffectOtherInstances() {
-        OpenFeatureAPI api1 = OpenFeatureAPIFactory.createAPI();
-        OpenFeatureAPI api2 = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI api1 = new OpenFeatureAPI();
+        OpenFeatureAPI api2 = new OpenFeatureAPI();
 
         NoOpHook hook = new NoOpHook();
         api1.addHooks(hook);
@@ -191,8 +191,8 @@ void clearHooksDoesNotAffectOtherInstances() {
     @Test
     @DisplayName("clients use their own instance's provider")
     void clientUsesItsOwnInstanceProvider() throws Exception {
-        OpenFeatureAPI api1 = OpenFeatureAPIFactory.createAPI();
-        OpenFeatureAPI api2 = OpenFeatureAPIFactory.createAPI();
+        OpenFeatureAPI api1 = new OpenFeatureAPI();
+        OpenFeatureAPI api2 = new OpenFeatureAPI();
 
         api1.setProviderAndWait(new InMemoryProvider(Map.of(
                 "flag1",
@@ -220,8 +220,8 @@ void warnWhenProviderBoundToMultipleInstances() {
         Logger mockLogger = Mockito.mock(Logger.class);
         LoggerMock.setMock(OpenFeatureAPI.class, mockLogger);
         try {
-            OpenFeatureAPI api1 = OpenFeatureAPIFactory.createAPI();
-            OpenFeatureAPI api2 = OpenFeatureAPIFactory.createAPI();
+            OpenFeatureAPI api1 = new OpenFeatureAPI();
+            OpenFeatureAPI api2 = new OpenFeatureAPI();
 
             NoOpProvider provider = new NoOpProvider();
             api1.setProvider(provider);