improve test, to ensure hook order.

Signed-off-by: Tobias Ibounig <tobias.ibounig@dynatrace.com>

Author: tobias-ibounig-dt

src/test/java/dev/openfeature/sdk/HookSupportTest.java

@@ -66,9 +66,9 @@ void shouldAlwaysCallGenericHook(FlagValueType flagValueType) {
         var hookSupportData = new HookSupportData();
         hookSupport.setHooks(
                 hookSupportData,
+                List.of(genericHook),
                 Collections.emptyList(),
                 Collections.emptyList(),
-                List.of(genericHook),
                 Collections.emptyList(),
                 flagValueType);
 
@@ -89,9 +89,9 @@ void shouldPassDataAcrossStages(FlagValueType flagValueType) {
         hookSupport.setHooks(
                 hookSupportData,
                 Collections.emptyList(),
-                Collections.emptyList(),
                 List.of(testHook),
                 Collections.emptyList(),
+                Collections.emptyList(),
                 flagValueType);
         hookSupport.setHookContexts(
                 hookSupportData,
@@ -125,8 +125,8 @@ void shouldIsolateDataBetweenHooks(FlagValueType flagValueType) {
                 hookSupportData,
                 Collections.emptyList(),
                 Collections.emptyList(),
-                List.of(testHook1, testHook2),
                 Collections.emptyList(),
+                List.of(testHook1, testHook2),
                 flagValueType);
         hookSupport.setHookContexts(
                 hookSupportData,
@@ -139,6 +139,28 @@ void shouldIsolateDataBetweenHooks(FlagValueType flagValueType) {
         assertHookData(testHook2, 2, "before", "after", "finallyAfter", "error");
     }
 
+    @Test
+    @DisplayName("should place hooks in provider → options → client → API order")
+    void shouldOrderHooksBySource() {
+        Hook<?> providerHook = mockGenericHook();
+        Hook<?> optionHook = mockGenericHook();
+        Hook<?> clientHook = mockGenericHook();
+        Hook<?> apiHook = mockGenericHook();
+
+        var hookSupportData = new HookSupportData();
+        hookSupport.setHooks(
+                hookSupportData,
+                List.of(providerHook),
+                List.of(optionHook),
+                List.of(clientHook),
+                List.of(apiHook),
+                FlagValueType.STRING);
+
+        assertThat(hookSupportData.getHooks())
+                .extracting(Pair::getKey)
+                .containsExactly(providerHook, optionHook, clientHook, apiHook);
+    }
+
     @Test
     void hookThatReturnsTheGivenContext_doesNotResultInAStackOverflow() {
         var hookSupportData = new HookSupportData();