fix: Ingress annotations not reconciling#773
Merged
beeme1mr merged 2 commits intoJul 14, 2025
Merged
Conversation
Y0sh1dk
changed the title
Signed-off-by: Yosiah de Koeyer <dev@yosiahdekoeyer.dev>
Signed-off-by: Yosiah de Koeyer <dev@yosiahdekoeyer.dev>
Y0sh1dk
force-pushed
the
fix/ingress-annotation-reconcile
branch
from
63b9c38 to
688c82d
Compare
lukas-reining
approved these changes
Jul 14, 2025
Member
lukas-reining
left a comment
lukas-reining
left a comment
There was a problem hiding this comment.
Thank you @Y0sh1dk!
This looks good!
beeme1mr
approved these changes
Jul 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #773 +/- ##
===========================================
- Coverage 86.51% 71.55% -14.97%
===========================================
Files 19 30 +11
Lines 1587 2299 +712
===========================================
+ Hits 1373 1645 +272
- Misses 173 606 +433
- Partials 41 48 +7
... and 11 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Fixes an issue where updating ingress annotations on
Flagdresources aren't reflected on the generatedIngressresource.Related Issues
Fixes #772
Notes
controllerutil.CreateOrUpdate()How to test