feat(flagd): add support for azure blob#779
Merged
Merged
Conversation
- fix for EnvVarKey function to prevent corrupting Azure related env vars keys Signed-off-by: vmai <maievskyivyacheslav89@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #779 +/- ##
===========================================
- Coverage 86.51% 71.25% -15.26%
===========================================
Files 19 30 +11
Lines 1587 2324 +737
===========================================
+ Hits 1373 1656 +283
- Misses 173 620 +447
- Partials 41 48 +7
... and 11 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@beeme1mr could you please have a look? |
beeme1mr
approved these changes
Sep 8, 2025
Member
beeme1mr
left a comment
There was a problem hiding this comment.
Thanks for the PR and sorry for the delayed approval. I had some feedback on the env changes but everything else looks good.
- fix for ToEnvVars function to not add prefix for Azure blob related env vars Signed-off-by: vmai <maievskyivyacheslav89@gmail.com>
lukas-reining
approved these changes
Oct 5, 2025
Member
lukas-reining
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks @VMaievskyi!
Merged
This was referenced Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Allow to configure Azure Blob as source for config
Verified that Flagd sidecar is created and connected to Azure Blob (SAS Key used for access)
Related Issues
Relates to:
#765
#758
Notes
At current moment it can work only with FeatureFlagSource.envVarPrefix = "" and spec.sidecarConfiguration: ""
as prefix breaks env var name and flagd cannot find mandatory env variables.
Follow-up Tasks
Fix flagd to search for Azure blob env vars ignoring prefix.
How to test
Works with end-to-end.yaml