feat: add configurable cluster domain support#789
Merged
Conversation
Add CLUSTER_DOMAIN environment variable to allow customization of the Kubernetes cluster domain used in flagd-proxy service URIs. The default value remains "cluster.local" to maintain backward compatibility. This enables support for clusters using non-standard domain configurations. Signed-off-by: Roman Kuznetsov <roku@lix.one>
guidobrei
approved these changes
Dec 15, 2025
Member
guidobrei
left a comment
guidobrei
left a comment
There was a problem hiding this comment.
Thanks for adding this contribution @kuznero, LGTM.
@toddbaert are there any maintainers assigned to the operator? There are not reviewers assigned to the PR.
beeme1mr
approved these changes
Dec 15, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #789 +/- ##
===========================================
- Coverage 86.51% 72.33% -14.19%
===========================================
Files 19 30 +11
Lines 1587 1923 +336
===========================================
+ Hits 1373 1391 +18
- Misses 173 484 +311
- Partials 41 48 +7
... and 25 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Any chance this can be merged/finalized? |
Member
Sorry for the delay @kuznero. Thanks for the PR. |
Merged
This was referenced Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CLUSTER_DOMAIN environment variable to allow customization of the Kubernetes cluster domain used in flagd-proxy service URIs. The default value remains "cluster.local" to maintain backward compatibility.
This enables support for clusters using non-standard domain configurations.
This PR
Related Issues
Fixes #764
Notes
Follow-up Tasks
How to test