Skip to content

feat: add latest flagd config fields, bump deps#818

Merged
toddbaert merged 2 commits into
mainfrom
feat/flagd-config-gaps
Apr 13, 2026
Merged

feat: add latest flagd config fields, bump deps#818
toddbaert merged 2 commits into
mainfrom
feat/flagd-config-gaps

Conversation

@toddbaert
Copy link
Copy Markdown
Member

@toddbaert toddbaert commented Apr 10, 2026

This PR adds configuration added to flagd since the last upgrade:

  • context-value (--context-value / -X): static key-value pairs for evaluation context
  • header-to-context mappings (--context-from-header / -H): map HTTP headers to context keys
  • CORS origins (--cors-origin / -C): allowed origins for the OFREP endpoint
  • OFREP port (--ofrep-port / -r): configurable port for the OFREP service
  • Bump flagd from v0.12.4 to v0.15.2
  • Bump flagd-proxy from v0.7.4 to v0.9.4
  • Update to oldest, still-supported Go version (1.25)

No e2e tests were added since none of these impact RBAC, topology, or deployment; just added unit tests that assert the associated startup args are correctly passed.

@toddbaert toddbaert force-pushed the feat/flagd-config-gaps branch from 9527eb0 to 509dc40 Compare April 10, 2026 21:14
This PR adds configuration added to flagd since the last upgrade:

- context-value (--context-value / -X): static key-value pairs for evaluation context
- header-to-context mappings (--context-from-header / -H): map HTTP headers to context keys
- CORS origins (--cors-origin / -C): allowed origins for the OFREP endpoint
- OFREP port (--ofrep-port / -r): configurable port for the OFREP service
- Bump flagd from v0.12.4 to v0.15.2
- Bump flagd-proxy from v0.7.4 to v0.9.4

No e2e tests were added since none of these impact RBAC, topology,
or deployment; just added unit tests that assert the associated
startup args are correctly passed.

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert force-pushed the feat/flagd-config-gaps branch from 509dc40 to ca5dc33 Compare April 10, 2026 21:16
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the FeatureFlagSource CRD by adding support for static context values, header-to-context mappings, CORS origin configuration, and a custom OFREP port. These new fields are integrated into the flagd sidecar injection logic and standalone deployment controller. Furthermore, the PR updates the default images for flagd to v0.15.2 and flagd-proxy to v0.9.4 across the codebase, documentation, and Helm charts. Feedback was provided regarding the manual modification of generated code in zz_generated.deepcopy.go, which should instead be handled by the project's generation tooling.

Comment thread api/core/v1beta1/zz_generated.deepcopy.go
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert force-pushed the feat/flagd-config-gaps branch from f3fa361 to dd8d6e0 Compare April 10, 2026 22:06
Comment thread .golangci.yml
@toddbaert toddbaert requested review from aepfli and marcozabel April 11, 2026 11:58
@toddbaert toddbaert changed the title feat: add new flagd config fields, bump versions feat: add latest flagd config fields, bump deps Apr 13, 2026
Copy link
Copy Markdown
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I can find no issue!

@toddbaert toddbaert added this pull request to the merge queue Apr 13, 2026
Merged via the queue into main with commit bf6c1ec Apr 13, 2026
19 checks passed
Y0sh1dk pushed a commit to Y0sh1dk/open-feature-operator that referenced this pull request Apr 22, 2026
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants