Skip to content

chore: remove replace, use new module#825

Merged
toddbaert merged 1 commit into
mainfrom
chore/use-api
Apr 13, 2026
Merged

chore: remove replace, use new module#825
toddbaert merged 1 commit into
mainfrom
chore/use-api

Conversation

@toddbaert
Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the open-feature-operator/api dependency to version v0.2.47 and removes the local replace directive in go.mod. Feedback suggests that removing the replace directive for a local sub-module may negatively impact the development workflow by preventing atomic changes and causing inconsistencies between local code and remote fetches.

I am having trouble creating individual review comments. Click here to see my feedback.

go.mod (108-109)

medium

Removing the replace directive for a sub-module (./api) that is part of the same repository is generally discouraged in a multi-module setup. This change forces the Go toolchain to fetch the api module from the remote repository instead of using the local source code. This breaks the ability to make atomic changes across both modules and can lead to inconsistencies during development and CI/CD, as local changes in the ./api directory will no longer be reflected in the operator's build. If the ./api directory is still intended to be part of this repository, consider retaining the replace directive or utilizing a Go workspace (go.work).

@toddbaert toddbaert merged commit 38672cd into main Apr 13, 2026
17 checks passed
This was referenced Apr 13, 2026
Y0sh1dk pushed a commit to Y0sh1dk/open-feature-operator that referenced this pull request Apr 22, 2026
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant