chore: remove replace, use new module#825
Conversation
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
64607df to
7f4e05e
Compare
There was a problem hiding this comment.
Code Review
This pull request updates the open-feature-operator/api dependency to version v0.2.47 and removes the local replace directive in go.mod. Feedback suggests that removing the replace directive for a local sub-module may negatively impact the development workflow by preventing atomic changes and causing inconsistencies between local code and remote fetches.
I am having trouble creating individual review comments. Click here to see my feedback.
go.mod (108-109)
Removing the replace directive for a sub-module (./api) that is part of the same repository is generally discouraged in a multi-module setup. This change forces the Go toolchain to fetch the api module from the remote repository instead of using the local source code. This breaks the ability to make atomic changes across both modules and can lead to inconsistencies during development and CI/CD, as local changes in the ./api directory will no longer be reflected in the operator's build. If the ./api directory is still intended to be part of this repository, consider retaining the replace directive or utilizing a Go workspace (go.work).
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
No description provided.