Skip to content

fix: Align FeatureFlagSource CRD defaults with documentation#838

Merged
beeme1mr merged 5 commits into
open-feature:mainfrom
Y0sh1dk:fix/flagd-default-probes
May 5, 2026
Merged

fix: Align FeatureFlagSource CRD defaults with documentation#838
beeme1mr merged 5 commits into
open-feature:mainfrom
Y0sh1dk:fix/flagd-default-probes

Conversation

@Y0sh1dk
Copy link
Copy Markdown
Contributor

@Y0sh1dk Y0sh1dk commented May 5, 2026

This PR

Aligns FeatureFlagSource CRD defaults with what is stated in the documentation.

Related Issues

Fixes #837

How to test

Signed-off-by: Yosiah de Koeyer <dev@yosiahdekoeyer.dev>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.42%. Comparing base (499661e) to head (c08f437).
⚠️ Report is 99 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #838       +/-   ##
===========================================
- Coverage   86.51%   69.42%   -17.10%     
===========================================
  Files          19       31       +12     
  Lines        1587     2008      +421     
===========================================
+ Hits         1373     1394       +21     
- Misses        173      561      +388     
- Partials       41       53       +12     
Files with missing lines Coverage Δ
api/core/v1beta1/featureflagsource_types.go 89.10% <ø> (ø)

... and 25 files with indirect coverage changes

Flag Coverage Δ
unit-tests 69.42% <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Y0sh1dk Y0sh1dk changed the title Align defaults with documentation and generate CRDs Fix: Align CRD defaults with documentation May 5, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces default values for the RolloutOnChange, ProbesEnabled, and DebugLogging fields in the FeatureFlagSource CRD by adding +kubebuilder:default markers to the Go types and updating the corresponding YAML schema. It also includes a minor formatting adjustment to the FeatureFlagSourceStatus struct. The review feedback suggests reordering the +optional and +kubebuilder:default markers to maintain consistency with existing field definitions in the codebase.

Comment thread api/core/v1beta1/featureflagsource_types.go Outdated
Comment thread api/core/v1beta1/featureflagsource_types.go Outdated
Comment thread api/core/v1beta1/featureflagsource_types.go Outdated
@Y0sh1dk Y0sh1dk changed the title Fix: Align CRD defaults with documentation Fix: Align FeatureFlagSource CRD defaults with documentation May 5, 2026
@Y0sh1dk Y0sh1dk changed the title Fix: Align FeatureFlagSource CRD defaults with documentation fix: Align FeatureFlagSource CRD defaults with documentation May 5, 2026
Y0sh1dk and others added 4 commits May 5, 2026 21:33
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Yosiah de Koeyer <47013245+Y0sh1dk@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Yosiah de Koeyer <47013245+Y0sh1dk@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Yosiah de Koeyer <47013245+Y0sh1dk@users.noreply.github.com>
Signed-off-by: Yosiah de Koeyer <dev@yosiahdekoeyer.dev>
@beeme1mr
Copy link
Copy Markdown
Member

beeme1mr commented May 5, 2026

Thanks @Y0sh1dk! I'm going to ignore the codecov error since it's just a documentation change.

@beeme1mr beeme1mr merged commit db0919e into open-feature:main May 5, 2026
18 of 19 checks passed
This was referenced May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standalone Flagd deployment missing liveness/readiness probes

2 participants