fix: Align FeatureFlagSource CRD defaults with documentation#838
Conversation
Signed-off-by: Yosiah de Koeyer <dev@yosiahdekoeyer.dev>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #838 +/- ##
===========================================
- Coverage 86.51% 69.42% -17.10%
===========================================
Files 19 31 +12
Lines 1587 2008 +421
===========================================
+ Hits 1373 1394 +21
- Misses 173 561 +388
- Partials 41 53 +12
... and 25 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request introduces default values for the RolloutOnChange, ProbesEnabled, and DebugLogging fields in the FeatureFlagSource CRD by adding +kubebuilder:default markers to the Go types and updating the corresponding YAML schema. It also includes a minor formatting adjustment to the FeatureFlagSourceStatus struct. The review feedback suggests reordering the +optional and +kubebuilder:default markers to maintain consistency with existing field definitions in the codebase.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Yosiah de Koeyer <47013245+Y0sh1dk@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Yosiah de Koeyer <47013245+Y0sh1dk@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Yosiah de Koeyer <47013245+Y0sh1dk@users.noreply.github.com>
Signed-off-by: Yosiah de Koeyer <dev@yosiahdekoeyer.dev>
|
Thanks @Y0sh1dk! I'm going to ignore the codecov error since it's just a documentation change. |
This PR
Aligns
FeatureFlagSourceCRD defaults with what is stated in the documentation.Related Issues
Fixes #837
How to test