fix(ofrep): handle 401, 403, 404 and 5xx errors explicitly and add tests

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>

Author: thomaspoignant

providers/openfeature-provider-ofrep/src/openfeature/contrib/provider/ofrep/__init__.py

@@ -183,6 +183,23 @@ def _handle_error(self, exception: requests.RequestException) -> NoReturn:
                 f"Rate limited, retry after: {retry_after}"
             ) from exception
 
+        if response.status_code == 401:
+            raise OpenFeatureError(ErrorCode.GENERAL, "unauthorized") from exception
+
+        if response.status_code == 403:
+            raise OpenFeatureError(ErrorCode.GENERAL, "forbidden") from exception
+
+        if response.status_code == 404:
+            try:
+                data = response.json()
+                error_details = data["errorDetails"]
+            except JSONDecodeError:
+                error_details = response.text
+            raise FlagNotFoundError(error_details) from exception
+
+        if response.status_code > 400:
+            raise OpenFeatureError(ErrorCode.GENERAL, response.text) from exception
+
         try:
             data = response.json()
         except JSONDecodeError:
@@ -191,9 +208,6 @@ def _handle_error(self, exception: requests.RequestException) -> NoReturn:
         error_code = ErrorCode(data["errorCode"])
         error_details = data["errorDetails"]
 
-        if response.status_code == 404:
-            raise FlagNotFoundError(error_details) from exception
-
         if error_code == ErrorCode.PARSE_ERROR:
             raise ParseError(error_details) from exception
         if error_code == ErrorCode.TARGETING_KEY_MISSING:

providers/openfeature-provider-ofrep/tests/test_provider.py

@@ -3,9 +3,11 @@
 from openfeature.contrib.provider.ofrep import OFREPProvider
 from openfeature.evaluation_context import EvaluationContext
 from openfeature.exception import (
+    ErrorCode,
     FlagNotFoundError,
     GeneralError,
     InvalidContextError,
+    OpenFeatureError,
     ParseError,
     TypeMismatchError,
 )
@@ -83,6 +85,61 @@ def test_provider_flag_not_found(ofrep_provider, requests_mock):
         ofrep_provider.resolve_boolean_details("flag_key", False)
 
 
+def test_provider_unauthorized(ofrep_provider, requests_mock):
+    requests_mock.post(
+        "http://localhost:8080/ofrep/v1/evaluate/flags/flag_key",
+        status_code=401,
+        text="unauthorized",
+    )
+
+    with pytest.raises(OpenFeatureError) as exc_info:
+        ofrep_provider.resolve_boolean_details("flag_key", False)
+
+    assert exc_info.value.error_code == ErrorCode.GENERAL
+    assert exc_info.value.error_message == "unauthorized"
+
+
+def test_provider_forbidden(ofrep_provider, requests_mock):
+    requests_mock.post(
+        "http://localhost:8080/ofrep/v1/evaluate/flags/flag_key",
+        status_code=403,
+        text="forbidden",
+    )
+
+    with pytest.raises(OpenFeatureError) as exc_info:
+        ofrep_provider.resolve_boolean_details("flag_key", False)
+
+    assert exc_info.value.error_code == ErrorCode.GENERAL
+    assert exc_info.value.error_message == "forbidden"
+
+
+def test_provider_flag_not_found_invalid_json(ofrep_provider, requests_mock):
+    """Test 404 with non-JSON response falls back to response text for error details"""
+    requests_mock.post(
+        "http://localhost:8080/ofrep/v1/evaluate/flags/flag_key",
+        status_code=404,
+        text="Flag not found - plain text response",
+    )
+
+    with pytest.raises(FlagNotFoundError, match="Flag not found - plain text response"):
+        ofrep_provider.resolve_boolean_details("flag_key", False)
+
+
+def test_provider_server_error(ofrep_provider, requests_mock):
+    """Test generic OpenFeatureError for status codes > 400 (e.g. 500, 502)"""
+    requests_mock.post(
+        "http://localhost:8080/ofrep/v1/evaluate/flags/flag_key",
+        status_code=500,
+        text="Internal Server Error",
+    )
+
+    with pytest.raises(OpenFeatureError) as exc_info:
+        ofrep_provider.resolve_boolean_details("flag_key", False)
+
+    assert exc_info.value.error_code == ErrorCode.GENERAL
+    assert exc_info.value.error_message == "Internal Server Error"
+
+
 def test_provider_invalid_context(ofrep_provider, requests_mock):
     requests_mock.post(
         "http://localhost:8080/ofrep/v1/evaluate/flags/flag_key",