Adding warn message

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>

Author: thomaspoignant

providers/openfeature-provider-ofrep/src/openfeature/contrib/provider/ofrep/__init__.py

@@ -1,3 +1,4 @@
+import logging
 import re
 from collections.abc import Mapping, Sequence
 from datetime import datetime, timedelta, timezone
@@ -30,6 +31,8 @@
 
 __all__ = ["OFREPProvider"]
 
+logger = logging.getLogger("openfeature.contrib.ofrep")
+
 
 TypeMap = dict[
     FlagType,
@@ -188,6 +191,9 @@ def _handle_error(self, exception: requests.RequestException) -> NoReturn:
         try:
             error_code = ErrorCode(data["errorCode"])
         except ValueError:
+            logger.warning(
+                "Invalid errorCode %r, falling back to GENERAL", data.get("errorCode")
+            )
             error_code = ErrorCode.GENERAL
         error_details = data["errorDetails"]
 

providers/openfeature-provider-ofrep/tests/test_provider.py

@@ -1,3 +1,5 @@
+import logging
+
 import pytest
 
 from openfeature.contrib.provider.ofrep import OFREPProvider
@@ -155,6 +157,28 @@ def test_provider_invalid_context(ofrep_provider, requests_mock):
         ofrep_provider.resolve_boolean_details("flag_key", False)
 
 
+def test_provider_invalid_error_code_logs_warning(
+    ofrep_provider, requests_mock, caplog
+):
+    requests_mock.post(
+        "http://localhost:8080/ofrep/v1/evaluate/flags/flag_key",
+        status_code=400,
+        json={
+            "key": "flag_key",
+            "errorCode": "UNKNOWN_CODE",
+            "errorDetails": "Something went wrong",
+        },
+    )
+
+    with (
+        caplog.at_level(logging.WARNING, logger="openfeature.contrib.ofrep"),
+        pytest.raises(GeneralError),
+    ):
+        ofrep_provider.resolve_boolean_details("flag_key", False)
+
+    assert any("UNKNOWN_CODE" in record.message for record in caplog.records)
+
+
 def test_provider_invalid_response(ofrep_provider, requests_mock):
     requests_mock.post(
         "http://localhost:8080/ofrep/v1/evaluate/flags/flag_key", text="invalid"