fixup: clamping impl consistency

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

Author: toddbaert

providers/openfeature-provider-flagd/src/openfeature/contrib/provider/flagd/resolvers/process/custom_ops.py

@@ -91,7 +91,8 @@ def _parse_fraction(arg: JsonLogicArg) -> Fraction:
 
     fraction = Fraction(variant=variant)
     if weight is not None:
-        fraction.weight = weight
+        # negative weights can be the result of rollout calculations, so we clamp to 0 rather than raising an error
+        fraction.weight = max(0, weight)
 
     return fraction
 

providers/openfeature-provider-flagd/tests/test_targeting.py

@@ -237,6 +237,16 @@ def test_weight_zero_bucket_never_wins(self):
         logic = targeting("flagA", rule, EvaluationContext(targeting_key="any"))
         assert logic == "always"
 
+    def test_negative_weight_clamped_to_zero(self):
+        rule = {
+            "fractional": [
+                ["on", -1000],
+                ["off", 1],
+            ],
+        }
+        logic = targeting("flagA", rule, EvaluationContext(targeting_key="any"))
+        assert logic == "off"
+
     def test_weight_as_fractional_float_is_invalid(self):
         rule = {
             "fractional": [