Skip to content

Commit 22d8203

Browse files
committed
fix: change log message to not duplicate stage
Signed-off-by: Danju Visvanathan <danju.visvanathan@gmail.com>
1 parent 8b3bc3a commit 22d8203

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

openfeature/hook/logging_hook.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def before(
4040
self, hook_context: HookContext, hints: HookHints
4141
) -> EvaluationContext | None:
4242
args = self._build_args(hook_context, "before")
43-
self.logger.debug("Before stage %s", args)
43+
self.logger.debug("Flag evaluation %s", args)
4444
return None
4545

4646
def after(
@@ -53,7 +53,7 @@ def after(
5353
args["reason"] = details.reason
5454
args["variant"] = details.variant
5555
args["value"] = details.value
56-
self.logger.debug("After stage %s", args)
56+
self.logger.debug("Flag evaluation %s", args)
5757

5858
def error(
5959
self, hook_context: HookContext, exception: Exception, hints: HookHints
@@ -65,4 +65,4 @@ def error(
6565
else ErrorCode.GENERAL
6666
)
6767
args["error_message"] = str(exception)
68-
self.logger.error("Error stage %s", args)
68+
self.logger.error("Flag evaluation %s", args)

tests/hook/test_logging_hook.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def test_before_calls_debug_with_stage(hook_context):
2727
hook = LoggingHook(logger=mock_logger)
2828
hook.before(hook_context, hints={})
2929
mock_logger.debug.assert_called_with(
30-
"Before stage %s",
30+
"Flag evaluation %s",
3131
{
3232
"stage": "before",
3333
"flag_key": "my-flag",
@@ -50,7 +50,7 @@ def test_after_calls_debug_with_stage(hook_context):
5050
hook.after(hook_context, details, hints={})
5151

5252
mock_logger.debug.assert_called_with(
53-
"After stage %s",
53+
"Flag evaluation %s",
5454
{
5555
"stage": "after",
5656
"flag_key": "my-flag",
@@ -76,7 +76,7 @@ def test_after_calls_debug_with_evaluation_context(hook_context):
7676
hook.after(hook_context, details, hints={})
7777

7878
mock_logger.debug.assert_called_with(
79-
"After stage %s",
79+
"Flag evaluation %s",
8080
{
8181
"stage": "after",
8282
"flag_key": "my-flag",
@@ -98,7 +98,7 @@ def test_error_calls_error_log(hook_context):
9898
hook.error(hook_context, exception, hints={})
9999

100100
mock_logger.error.assert_called_with(
101-
"Error stage %s",
101+
"Flag evaluation %s",
102102
{
103103
"stage": "error",
104104
"flag_key": "my-flag",
@@ -118,7 +118,7 @@ def test_error_extracts_error_code_from_open_feature_error(hook_context):
118118
hook.error(hook_context, exception, hints={})
119119

120120
mock_logger.error.assert_called_with(
121-
"Error stage %s",
121+
"Flag evaluation %s",
122122
{
123123
"stage": "error",
124124
"flag_key": "my-flag",
@@ -183,7 +183,7 @@ def test_error_calls_error_log_with_evaluation_context(hook_context):
183183
hook.error(hook_context, exception, hints={})
184184

185185
mock_logger.error.assert_called_with(
186-
"Error stage %s",
186+
"Flag evaluation %s",
187187
{
188188
"stage": "error",
189189
"flag_key": "my-flag",

0 commit comments

Comments
 (0)