Skip to content

Commit 63c5a5b

Browse files
committed
chore: remove unnecessary async from tests
Signed-off-by: Danju Visvanathan <danju.visvanathan@gmail.com>
1 parent 7a0993e commit 63c5a5b

File tree

2 files changed

+13
-16
lines changed

2 files changed

+13
-16
lines changed

tests/test_client.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -625,16 +625,14 @@ def test_client_should_merge_contexts():
625625
assert context.attributes["client_attr"] == "client_value"
626626
assert context.attributes["invocation_attr"] == "invocation_value"
627627

628-
@pytest.mark.asyncio
629-
async def test_client_should_track_event():
628+
def test_client_should_track_event():
630629
spy_provider = MagicMock(spec=NoOpProvider)
631630
set_provider(spy_provider)
632631
client = get_client()
633632
client.track(tracking_event_name="test")
634633
spy_provider.track.assert_called_once()
635634

636-
@pytest.mark.asyncio
637-
async def test_tracking_merges_evaluation_contexts():
635+
def test_tracking_merges_evaluation_contexts():
638636
spy_provider = MagicMock(spec=NoOpProvider)
639637
api.set_provider(spy_provider)
640638
client = get_client()
@@ -644,8 +642,7 @@ async def test_tracking_merges_evaluation_contexts():
644642
spy_provider.track.assert_called_once_with("test", EvaluationContext("id", attributes={"transaction_attr": "transaction_value", "key": "value"}), None)
645643

646644

647-
@pytest.mark.asyncio
648-
async def test_should_noop_if_provider_does_not_support_tracking(monkeypatch):
645+
def test_should_noop_if_provider_does_not_support_tracking(monkeypatch):
649646
provider = NoOpProvider()
650647
monkeypatch.delattr(NoOpProvider, "track", False)
651648
set_provider(provider)

tests/track/test_tracking.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,30 @@
11
from openfeature.track import TrackingEventDetails
22
import pytest
33

4-
@pytest.mark.asyncio
5-
async def test_add_attribute_to_tracking_event_details():
4+
def test_add_attribute_to_tracking_event_details():
65
tracking_event_details = TrackingEventDetails()
76
tracking_event_details.add("key", "value")
87
assert tracking_event_details.attributes == {"key": "value"}
98

10-
@pytest.mark.asyncio
11-
async def test_get_value_from_tracking_event_details():
9+
def test_add_attribute_to_tracking_event_details_dict():
10+
tracking_event_details = TrackingEventDetails()
11+
tracking_event_details.add("key", {"key1": "value1", "key2": "value2"})
12+
assert tracking_event_details.attributes == {"key": {"key1": "value1", "key2": "value2"}}
13+
14+
def test_get_value_from_tracking_event_details():
1215
tracking_event_details = TrackingEventDetails(value=1)
1316
assert tracking_event_details.value == 1
1417

15-
@pytest.mark.asyncio
16-
async def test_get_attributes_from_tracking_event_details():
18+
def test_get_attributes_from_tracking_event_details():
1719
tracking_event_details = TrackingEventDetails(value=5.0, attributes={"key": "value"})
1820
assert tracking_event_details.attributes == {"key": "value"}
1921

20-
@pytest.mark.asyncio
21-
async def test_get_attributes_from_tracking_event_details_with_none_value():
22+
def test_get_attributes_from_tracking_event_details_with_none_value():
2223
tracking_event_details = TrackingEventDetails(attributes={"key": "value"})
2324
assert tracking_event_details.attributes == {"key": "value"}
2425
assert tracking_event_details.value is None
2526

26-
@pytest.mark.asyncio
27-
async def test_get_attributes_from_tracking_event_details_with_none_attributes():
27+
def test_get_attributes_from_tracking_event_details_with_none_attributes():
2828
tracking_event_details = TrackingEventDetails(value=5.0)
2929
assert tracking_event_details.attributes == {}
3030
assert tracking_event_details.value == 5.0

0 commit comments

Comments
 (0)